Include exception message in ErrorAnalysisCard subtitle#4982
Open
shrutipatel31 wants to merge 1 commit intofacebook:mainfrom
Open
Include exception message in ErrorAnalysisCard subtitle#4982shrutipatel31 wants to merge 1 commit intofacebook:mainfrom
shrutipatel31 wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: The exception message is now displayed in the ErrorAnalysisCard subtitle, allowing users to immediately see the reasoning (e.g., why an analysis is not applicable) without needing to expand the error card. Previously, the subtitle only showed a generic message like "AnalysisNotApplicableStateError encountered while computing ParallelCoordinatesPlot." Now it shows the actual exception message, such as "AnalysisNotApplicableStateError: Experiment has no trials", providing immediate context. Differential Revision: D94617700
|
@shrutipatel31 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D94617700. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4982 +/- ##
==========================================
- Coverage 96.82% 96.82% -0.01%
==========================================
Files 599 599
Lines 64424 64427 +3
==========================================
+ Hits 62380 62382 +2
- Misses 2044 2045 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The exception message is now displayed in the ErrorAnalysisCard subtitle, allowing users to immediately see the reasoning (e.g., why an analysis is not applicable) without needing to expand the error card.
Previously, the subtitle only showed a generic message like "AnalysisNotApplicableStateError encountered while computing ParallelCoordinatesPlot." Now it shows the actual exception message, such as "AnalysisNotApplicableStateError: Experiment has no trials", providing immediate context.
Differential Revision: D94617700