Skip to content

Include exception message in ErrorAnalysisCard subtitle#4982

Open
shrutipatel31 wants to merge 1 commit intofacebook:mainfrom
shrutipatel31:export-D94617700
Open

Include exception message in ErrorAnalysisCard subtitle#4982
shrutipatel31 wants to merge 1 commit intofacebook:mainfrom
shrutipatel31:export-D94617700

Conversation

@shrutipatel31
Copy link
Contributor

Summary:
The exception message is now displayed in the ErrorAnalysisCard subtitle, allowing users to immediately see the reasoning (e.g., why an analysis is not applicable) without needing to expand the error card.

Previously, the subtitle only showed a generic message like "AnalysisNotApplicableStateError encountered while computing ParallelCoordinatesPlot." Now it shows the actual exception message, such as "AnalysisNotApplicableStateError: Experiment has no trials", providing immediate context.

Differential Revision: D94617700

Summary:
The exception message is now displayed in the ErrorAnalysisCard subtitle, allowing users to immediately see the reasoning (e.g., why an analysis is not applicable) without needing to expand the error card.

Previously, the subtitle only showed a generic message like "AnalysisNotApplicableStateError encountered while computing ParallelCoordinatesPlot." Now it shows the actual exception message, such as "AnalysisNotApplicableStateError: Experiment has no trials", providing immediate context.

Differential Revision: D94617700
@meta-cla meta-cla bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 5, 2026
@meta-codesync
Copy link

meta-codesync bot commented Mar 5, 2026

@shrutipatel31 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D94617700.

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.82%. Comparing base (3df1600) to head (2c0a65a).

Files with missing lines Patch % Lines
ax/analysis/analysis.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4982      +/-   ##
==========================================
- Coverage   96.82%   96.82%   -0.01%     
==========================================
  Files         599      599              
  Lines       64424    64427       +3     
==========================================
+ Hits        62380    62382       +2     
- Misses       2044     2045       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants