Add suggested_experiment_status to legacy GS dispatch --> have AxSweep experiment status appear in the UI (#5056)#5056
Closed
lena-kashtelyan wants to merge 1 commit intofacebook:mainfrom
Closed
Conversation
meta-cla
bot
added
the
CLA Signed
|
@lena-kashtelyan has exported this pull request. If you are a Meta employee, you can view the originating Diff in D96784737. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5056 +/- ##
=======================================
Coverage 96.29% 96.29%
=======================================
Files 611 611
Lines 67314 67325 +11
=======================================
+ Hits 64822 64833 +11
Misses 2492 2492 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…p experiment status appear in the UI (facebook#5056) Summary: Add `suggested_experiment_status` to the `GenerationStep`s created by `choose_generation_strategy_legacy`. The Sobol step gets `ExperimentStatus.INITIALIZATION` and the BayesOpt step gets `ExperimentStatus.OPTIMIZATION`, matching the convention used by all other GS factory functions. Differential Revision: D96784737
meta-codesync
bot
changed the title
lena-kashtelyan
force-pushed
the
export-D96784737
branch
from
5123653 to
37478b3
Compare
|
This pull request has been merged in 33e9a5e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add
suggested_experiment_statusto theGenerationSteps created bychoose_generation_strategy_legacy. The Sobol step getsExperimentStatus.INITIALIZATIONand the BayesOpt step getsExperimentStatus.OPTIMIZATION, matching the convention used byall other GS factory functions.
Differential Revision: D96784737