Make infeasible arm red hover outlines 40% opaque#5057
Closed
lena-kashtelyan wants to merge 1 commit into
Closed
Conversation
Summary:
Saw the bright red, found it a bit jarring:
{F1986915507}
Updating to (from N9873964):
{F1986917158}
---
Claude stuff
[ax] Make infeasible arm red hover outlines 60% opaque
The red outlines added by D94783502 for infeasible arms in ScatterPlot and
ArmEffectsPlot are fully opaque. This makes them 60% opaque by changing the
INFEASIBLE_OUTLINE_COLOR from 'red' to 'rgba(255, 0, 0, 0.6)', resulting
in a softer visual indicator that is less visually jarring while still
clearly marking constraint violations.
Changes:
- plotly/utils.py: Change INFEASIBLE_OUTLINE_COLOR from 'red' to 'rgba(255, 0, 0, 0.6)'
- Tests: Update test assertions to match new rgba color value
Differential Revision: D96936657
meta-cla
Bot
added
the
CLA Signed
|
@lena-kashtelyan has exported this pull request. If you are a Meta employee, you can view the originating Diff in D96936657. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5057 +/- ##
=======================================
Coverage 96.30% 96.30%
=======================================
Files 613 613
Lines 66993 66993
=======================================
+ Hits 64515 64516 +1
+ Misses 2478 2477 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been merged in 3280609. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Saw the bright red, found it a bit jarring:
{F1986915507}
Updating to (from N9873964):
{F1986917158}
Claude stuff
[ax] Make infeasible arm red hover outlines 60% opaque
The red outlines added by D94783502 for infeasible arms in ScatterPlot and
ArmEffectsPlot are fully opaque. This makes them 60% opaque by changing the
INFEASIBLE_OUTLINE_COLOR from 'red' to 'rgba(255, 0, 0, 0.6)', resulting
in a softer visual indicator that is less visually jarring while still
clearly marking constraint violations.
Changes:
Differential Revision: D96936657