Raise UnsupportedError for scalarized objectives in best_point_mixin and report_utils#5065
Closed
saitcakmak wants to merge 1 commit into
Closed
Raise UnsupportedError for scalarized objectives in best_point_mixin and report_utils#5065saitcakmak wants to merge 1 commit into
saitcakmak wants to merge 1 commit into
Conversation
…and report_utils Summary: Several methods in `best_point_mixin.py` and `report_utils.py` use `metric_names[0]` as the objective metric and call `.minimize`, which is semantically wrong for scalarized objectives (where the objective is a combination of metrics). Add early guards raising `UnsupportedError`. Affected methods: - `_get_trace_by_progression` - `get_improvement_over_baseline` - `_get_objective_trace_plot` - `maybe_extract_baseline_comparison_values` Differential Revision: D97123523
meta-cla
Bot
added
the
CLA Signed
|
@saitcakmak has exported this pull request. If you are a Meta employee, you can view the originating Diff in D97123523. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5065 +/- ##
=======================================
Coverage 96.29% 96.29%
=======================================
Files 613 613
Lines 67152 67187 +35
=======================================
+ Hits 64664 64700 +36
+ Misses 2488 2487 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been merged in 04c9aba. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Several methods in
best_point_mixin.pyandreport_utils.pyusemetric_names[0]as the objective metric and call.minimize, which issemantically wrong for scalarized objectives (where the objective is a
combination of metrics). Add early guards raising
UnsupportedError.Affected methods:
_get_trace_by_progressionget_improvement_over_baseline_get_objective_trace_plotmaybe_extract_baseline_comparison_valuesDifferential Revision: D97123523