Clean up sampler usage in pick_best_out_of_sample_point_acqf_class (#5095)#5095
Closed
saitcakmak wants to merge 1 commit into
Closed
Clean up sampler usage in pick_best_out_of_sample_point_acqf_class (#5095)#5095saitcakmak wants to merge 1 commit into
saitcakmak wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@saitcakmak has exported this pull request. If you are a Meta employee, you can view the originating Diff in D97956036. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5095 +/- ##
==========================================
- Coverage 96.41% 96.40% -0.01%
==========================================
Files 613 613
Lines 68194 68186 -8
==========================================
- Hits 65747 65738 -9
- Misses 2447 2448 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
meta-codesync
Bot
changed the title
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Mar 31, 2026
…acebook#5095) Summary: This was generating a SobolQMCSampler regardless of the model it is used with. SobolQMCSampler does not support PosteriorList, which was leading to issues with LILO integration. This diff cleans up the generated options in `pick_best_out_of_sample_point_acqf_class`, since BoTorch (in `MCSamplerMixin.get_posterior_samples`) will dispatch to proper defaults without them. This led to the `options` input becoming unused, so I removed those rather than having them get ignored silently. Differential Revision: D97956036
saitcakmak
force-pushed
the
export-D97956036
branch
from
39cb5b2 to
4f16764
Compare
…acebook#5095) Summary: This was generating a SobolQMCSampler regardless of the model it is used with. SobolQMCSampler does not support PosteriorList, which was leading to issues with LILO integration. This diff cleans up the generated options in `pick_best_out_of_sample_point_acqf_class`, since BoTorch (in `MCSamplerMixin.get_posterior_samples`) will dispatch to proper defaults without them. This led to the `options` input becoming unused, so I removed those rather than having them get ignored silently. Differential Revision: D97956036
saitcakmak
force-pushed
the
export-D97956036
branch
from
4f16764 to
b079983
Compare
|
This pull request has been merged in efd72a6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This was generating a SobolQMCSampler regardless of the model it is used with. SobolQMCSampler does not support PosteriorList, which was leading to issues with LILO integration. This diff cleans up the generated options in
pick_best_out_of_sample_point_acqf_class, since BoTorch (inMCSamplerMixin.get_posterior_samples) will dispatch to proper defaults without them.This led to the
optionsinput becoming unused, so I removed those rather than having them get ignored silently.Differential Revision: D97956036