Skip to content

Fix typo: get_aditional_attrs -> get_additional_attrs #5123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shrutipatel31 wants to merge 1 commit into from
Closed

Fix typo: get_aditional_attrs -> get_additional_attrs #5123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ax/analysis/healthcheck/healthcheck_analysis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def is_user_facing(self) -> bool:
"""
return self.get_status() != HealthcheckStatus.PASS

def get_aditional_attrs(self) -> dict[str, str | int | float | bool]:
def get_additional_attrs(self) -> dict[str, str | int | float | bool]:
return json.loads(self.blob)


Expand Down
8 changes: 4 additions & 4 deletions ax/analysis/healthcheck/tests/test_can_generate_candidates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def test_passes_if_can_generate(self) -> None:
)
self.assertEqual(card.get_status(), HealthcheckStatus.PASS)
self.assertDictEqual(
card.get_aditional_attrs(),
card.get_additional_attrs(),
{
"status": HealthcheckStatus.PASS,
"reason": "No problems found.",
Expand Down Expand Up @@ -73,7 +73,7 @@ def test_warns_if_a_trial_was_recently_run(self) -> None:
)
self.assertEqual(card.get_status(), HealthcheckStatus.INFO)
self.assertDictEqual(
card.get_aditional_attrs(),
card.get_additional_attrs(),
{
"status": HealthcheckStatus.INFO,
"reason": "The data is borked.",
Expand Down Expand Up @@ -106,7 +106,7 @@ def test_is_fail_no_trials_have_been_run(self) -> None:
)
self.assertEqual(card.get_status(), HealthcheckStatus.FAIL)
self.assertDictEqual(
card.get_aditional_attrs(),
card.get_additional_attrs(),
{
"status": HealthcheckStatus.FAIL,
"reason": "The data is gone.",
Expand Down Expand Up @@ -143,7 +143,7 @@ def test_is_fail_if_no_trial_was_recently_run(self) -> None:
)
self.assertEqual(card.get_status(), HealthcheckStatus.FAIL)
self.assertDictEqual(
card.get_aditional_attrs(),
card.get_additional_attrs(),
{
"status": HealthcheckStatus.FAIL,
"reason": "The data is old.",
Expand Down
4 changes: 2 additions & 2 deletions ax/analysis/healthcheck/tests/test_complexity_rating.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ def test_standard_configuration(self) -> None:
self.assertTrue(card.is_passing())
self.assertEqual(card.get_status(), HealthcheckStatus.PASS)
self.assertIn("Standard", card.subtitle)
self.assertEqual(card.get_aditional_attrs()["tier"], "Standard")
self.assertEqual(card.get_additional_attrs()["tier"], "Standard")

def test_parameter_counts(self) -> None:
test_cases = [
Expand All @@ -88,7 +88,7 @@ def test_parameter_counts(self) -> None:
self.assertEqual(card.get_status(), expected_status)
self.assertIn(expected_tier, card.subtitle)
self.assertIn(expected_msg, card.subtitle)
self.assertEqual(card.get_aditional_attrs()["tier"], expected_tier)
self.assertEqual(card.get_additional_attrs()["tier"], expected_tier)

def test_objectives_count(self) -> None:
test_cases = [
Expand Down
Loading