Implement Runner.on_search_space_update#5132
Open
Cesar-Cardoso wants to merge 3 commits intofacebook:mainfrom
Open
Implement Runner.on_search_space_update#5132Cesar-Cardoso wants to merge 3 commits intofacebook:mainfrom
Runner.on_search_space_update#5132Cesar-Cardoso wants to merge 3 commits intofacebook:mainfrom
Conversation
Summary: Add UNSET sentinel class in ax/utils/common/sentinel.py for distinguishing "not provided" from None in runner config updates Reviewed By: andycylmeta Differential Revision: D97988143
Summary: Introduce `RunnerConfig` base class in `runner.py` with nested `SearchSpaceUpdateArguments` and `RunnerUpdateArguments` frozen dataclasses, and a `config_type` ClassVar on `Runner` so each runner subclass can declare its config type. Reviewed By: andycylmeta Differential Revision: D99150292
Summary: Pass through arguments for runner updates as a side-effect of search space updates. Called by AxClient when making search space updates. New search space update methods in AxClient now take in an optional `RunnerConfig.SearchSpaceUpdateArguments` Differential Revision: D97988196
meta-cla
bot
added
the
CLA Signed
|
@Cesar-Cardoso has exported this pull request. If you are a Meta employee, you can view the originating Diff in D97988196. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5132 +/- ##
========================================
Coverage 96.40% 96.41%
========================================
Files 613 614 +1
Lines 68171 68360 +189
========================================
+ Hits 65721 65906 +185
- Misses 2450 2454 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Cesar-Cardoso
added a commit
to Cesar-Cardoso/Ax
that referenced
this pull request
Apr 3, 2026
Summary: Pass through arguments for runner updates as a side-effect of search space updates. Called by AxClient when making search space updates. New search space update methods in AxClient now take in an optional `RunnerConfig.SearchSpaceUpdateArguments` Reviewed By: andycylmeta Differential Revision: D97988196
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Pass through arguments for runner updates as a side-effect of search space updates. Called by AxClient when making search space updates. New search space update methods in AxClient now take in an optional
RunnerConfig.SearchSpaceUpdateArgumentsDifferential Revision: D97988196