Auto-register extraneous metrics as tracking metrics in Client.attach_data#5135
Closed
saitcakmak wants to merge 1 commit into
Closed
Auto-register extraneous metrics as tracking metrics in Client.attach_data#5135saitcakmak wants to merge 1 commit into
saitcakmak wants to merge 1 commit into
Conversation
…_data Summary: The `Client.attach_data` docstring claims unexpected metric values will be added as tracking metrics, but the code actually raises a `UserInputError`. This diff fixes the implementation to match the docstring: extraneous metrics in `raw_data` are now auto-registered via `configure_tracking_metrics` before the data is passed downstream. This also applies to `Client.complete_trial` since it delegates to `attach_data`. Differential Revision: D99386924
meta-cla
Bot
added
the
CLA Signed
|
@saitcakmak has exported this pull request. If you are a Meta employee, you can view the originating Diff in D99386924. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5135 +/- ##
==========================================
- Coverage 96.40% 96.40% -0.01%
==========================================
Files 613 613
Lines 68187 68190 +3
==========================================
+ Hits 65737 65739 +2
- Misses 2450 2451 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been merged in 227243c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The
Client.attach_datadocstring claims unexpected metric values will be added as tracking metrics, but the code actually raises aUserInputError. This diff fixes the implementation to match the docstring: extraneous metrics inraw_dataare now auto-registered viaconfigure_tracking_metricsbefore the data is passed downstream.This also applies to
Client.complete_trialsince it delegates toattach_data.Differential Revision: D99386924