Allow DiagnosticAnalysis with missing opt config metrics#5159
Closed
bletham wants to merge 1 commit into
Closed
Conversation
Summary: Filter DiagnosticAnalysis metrics to only those present in the adapter's optimization config, gracefully handling cases where the adapter cannot be extracted. This prevents errors when the experiment has metrics not included in the optimization configuration. The commit adds a try/except block in DiagnosticAnalysis that uses extract_relevant_adapter to identify which metrics are actually in the optimization config, filtering out any that aren't. If the adapter can't be extracted, it silently continues with the original metric list. Differential Revision: D100103284
|
@bletham has exported this pull request. If you are a Meta employee, you can view the originating Diff in D100103284. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5159 +/- ##
=======================================
Coverage 96.39% 96.40%
=======================================
Files 614 614
Lines 68621 68644 +23
=======================================
+ Hits 66150 66173 +23
Misses 2471 2471 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been merged in 733320e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Filter DiagnosticAnalysis metrics to only those present in the adapter's optimization config, gracefully handling cases where the adapter cannot be extracted. This prevents errors when the experiment has metrics not included in the optimization configuration.
The commit adds a try/except block in DiagnosticAnalysis that uses extract_relevant_adapter to identify which metrics are actually in the optimization config, filtering out any that aren't. If the adapter can't be extracted, it silently continues with the original metric list.
Differential Revision: D100103284