Skip to content

Remove generated_points argument to RandomGenerator (#5186) #5186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
esantorella wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −17
Open

Remove generated_points argument to RandomGenerator (#5186) #5186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions ax/generators/random/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,6 @@ class RandomGenerator(Generator):
of samples to fast-forward before generating new samples.
Used to ensure that the re-loaded generator will continue generating
from the same sequence rather than starting from scratch.
generated_points: A set of previously generated points to use
for deduplication. These should be provided in the raw transformed
space the model operates in.
fallback_to_sample_polytope: If True, when rejection sampling fails,
we fall back to the HitAndRunPolytopeSampler.
"""
Expand All @@ -69,7 +66,6 @@ def __init__(
deduplicate: bool = True,
seed: int | None = None,
init_position: int = 0,
generated_points: npt.NDArray | None = None,
fallback_to_sample_polytope: bool = False,
polytope_sampler_kwargs: dict[str, Any] | None = None,
) -> None:
Expand All @@ -86,15 +82,6 @@ def __init__(
self.polytope_sampler_kwargs: dict[str, Any] = polytope_sampler_kwargs or {}
self._bounds: npt.NDArray = np.empty((0, 2))
self.attempted_draws: int = 0
if generated_points is not None:
# generated_points was deprecated in Ax 1.0.0, so it can now be reaped.
warnings.warn(
"The `generated_points` argument is deprecated and will be removed "
"in a future version of Ax. It is being ignored in favor of "
"extracting the generated points directly from the experiment.",
DeprecationWarning,
stacklevel=2,
)

@property
def can_predict(self) -> bool:
Expand Down
2 changes: 0 additions & 2 deletions ax/generators/random/sobol.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,13 @@ def __init__(
seed: int | None = None,
init_position: int = 0,
scramble: bool = True,
generated_points: npt.NDArray | None = None,
fallback_to_sample_polytope: bool = False,
polytope_sampler_kwargs: dict[str, Any] | None = None,
) -> None:
super().__init__(
deduplicate=deduplicate,
seed=seed,
init_position=init_position,
generated_points=generated_points,
fallback_to_sample_polytope=fallback_to_sample_polytope,
polytope_sampler_kwargs=polytope_sampler_kwargs,
)
Expand Down
2 changes: 0 additions & 2 deletions ax/generators/random/uniform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,12 @@ def __init__(
deduplicate: bool = True,
seed: int | None = None,
init_position: int = 0,
generated_points: npt.NDArray | None = None,
fallback_to_sample_polytope: bool = False,
) -> None:
super().__init__(
deduplicate=deduplicate,
seed=seed,
init_position=init_position,
generated_points=generated_points,
fallback_to_sample_polytope=fallback_to_sample_polytope,
)
self._rs = np.random.RandomState(seed=self.seed)
Expand Down
Loading