Skip to content

Remove deprecated argument use_update to GenerationStep (#5187) #5187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
esantorella wants to merge 1 commit into from
+0 −6
Closed

Remove deprecated argument use_update to GenerationStep (#5187) #5187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions ax/generation_strategy/generation_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -983,7 +983,6 @@ class GenerationStep:
to `generation_strategy.gen` will fail with a `MaxParallelismReached
Exception`, indicating that more trials need to be completed before
generating and running next trials.
use_update: DEPRECATED.
enforce_num_trials: Whether to enforce that only `num_trials` are generated
from the given step. If False and `num_trials` have been generated, but
`min_trials_observed` have not been completed, `generation_strategy.gen`
Expand Down Expand Up @@ -1037,7 +1036,6 @@ def __new__(
should_deduplicate: bool = False,
generator_name: str | None = None,
use_all_trials_in_exp: bool = False,
use_update: bool = False, # DEPRECATED.
index: int = -1, # Index of this step, set internally.
suggested_experiment_status: ExperimentStatus | None = None,
# Deprecated arguments for backwards compatibility.
Expand All @@ -1051,9 +1049,6 @@ def __new__(
Returns:
A ``GenerationNode`` instance configured with the provided step parameters.
"""
if use_update:
raise DeprecationWarning("`GenerationStep.use_update` is deprecated.")

if num_trials < 1 and num_trials != -1:
raise UserInputError(
"`num_trials` must be positive or -1 (indicating unlimited) "
Expand Down
1 change: 0 additions & 1 deletion ax/utils/testing/modeling_stubs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,6 @@ def get_legacy_list_surrogate_generation_step_as_dict() -> dict[str, Any]:
"min_trials_observed": 0,
"completion_criteria": [],
"max_parallelism": 1,
"use_update": False,
"enforce_num_trials": True,
"model_kwargs": {
"surrogate": {
Expand Down
Loading