Add tests for find_sources, gen-source-db, run-tree#7
Closed
msullivan wants to merge 3 commits into
Closed
Conversation
Most of the tests test the shared find_sources code directly, but also add a smoke test each for run-tree and gen-source-db that verify they are both supporting site-packages.
martindemello
requested changes
Apr 21, 2026
martindemello
left a comment
martindemello
left a comment
Contributor
There was a problem hiding this comment.
looks good, just move the helper function to the existing test lib
msullivan
force-pushed
the
fs-test
branch
3 times, most recently
from
bc15663 to
ba13172
Compare
martindemello
approved these changes
Apr 22, 2026
martindemello
approved these changes
Apr 22, 2026
|
@martindemello has imported this pull request. If you are a Meta employee, you can view this in D102024363. |
martindemello
requested changes
Apr 22, 2026
| run(args).unwrap(); | ||
|
|
||
| let content = fs::read_to_string(&output).unwrap(); | ||
| let value: serde_json::Value = serde_json::from_str(&content).unwrap(); |
Contributor
There was a problem hiding this comment.
lint: use serde_json::Value
brittanyrey
requested changes
Apr 22, 2026
| use pyrefly_python::module::Module; | ||
| use pyrefly_python::module_name::ModuleName; | ||
| use rayon::prelude::*; | ||
| use tempfile::TempDir; |
Contributor
There was a problem hiding this comment.
error[[E0432](https://www.internalfb.com/servicelab/experiment/0432)]: unresolved import `tempfile`
--> fbcode/safer_lazy_imports/lifeguard/src/test_lib.rs:19:5
|
19 | use tempfile::TempDir;
| ^^^^^^^^ use of unresolved module or unlinked crate `tempfile`
|
= help: you might be missing a crate named `tempfile`
|
@brittanyrey merged this pull request in 26fb058. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the tests test the shared find_sources code directly, but also
add a smoke test each for run-tree and gen-source-db that verify they
are both supporting site-packages.