minerva-ag: Support i2c telemetry command and support fru product custom data and modify bootstrap command with setting hex-value by LisaChang-Quanta · Pull Request #2261 · facebook/OpenBIC

LisaChang-Quanta · 2025-03-07T01:28:46Z

Summary:

Support i2c telemetry command
Support reg: 0x00 ~ 0x05
Support part of reg: 0x06
Add comment on i2c_target_config: rd_data_collect_func
Support fru product custom data
Support i2c telemetry write command
Support reg: 0x08 ~ 0x76
modify bootstrap command with setting hex-value
modify_telemetry_with_bootstrap_command, reg:0x09
modify telemetry offset 0x08 format
Support i2c telemetry i2c bridge master write/read command
Support reg: 0x40 ~ 0x42
Modify bootstrap default value
base on cpld version: 0070d010
change: SOC_BOOT_SOURCE_0_4, S_OWL_BOOT_SOURCE_0_7, N_OWL_BOOT_SOURCE_0_7
Support telemetry control sensor polling command
Support reg: 0xF0

Test Plan:

Build code: PASS

facebook-github-bot · 2025-03-07T01:28:55Z

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. (Because this pull request was imported automatically, there will not be any future comments.)

jamesatha · 2025-03-13T19:21:30Z

meta-facebook/minerva-ag/src/platform/plat_hook.c

+	ARG_UNUSED(args);
+
+	update_sensor_data_0_2_table();
+


Is there a reason why we aren't updating the other sensors?

jamesatha · 2025-03-13T19:22:53Z

meta-facebook/minerva-ag/src/platform/plat_i2c_target.c

+plat_sensor_init_data_0_1 *sensor_init_data_0_1_table[2] = { NULL };
+plat_sensor_init_data_0_2 *sensor_init_data_0_2_table[4] = { NULL };
+plat_sensor_init_data_0_6 *sensor_init_data_0_6_table[1] = { NULL };


What's the rationale for using malloc instead of making this statically assigned?

jamesatha · 2025-03-13T19:28:23Z

meta-facebook/minerva-ag/src/platform/plat_i2c_target.c

+
+void init_sensor_data_0_1_table()
+{
+	for (int reg_offset = 0; reg_offset < 2; reg_offset++) {


For all of these for loops, that use reg_offset, it's not clear that you are going through all the elements in the corresponding array. Can we create variables/constants to make the relationship clear?

#define DATA_0_1_TABLE_LENGTH 2 plat_sensor_init_data_0_1 *sensor_init_data_0_1_table[DATA_0_1_TABLE_LENGTH] = ... for (int reg_offset = 0; reg_offset < DATA_0_1_TABLE_LENGTH; reg_offset++) {

jamesatha · 2025-03-13T19:29:15Z

meta-facebook/minerva-ag/src/platform/plat_i2c_target.c

+{
+	for (int reg_offset = 0; reg_offset < 2; reg_offset++) {
+		// Calculate num_idx
+		int num_idx = (PLAT_SENSOR_NUM_MAX - 1) - (248 * reg_offset);


What is 248 and can we make a variable/constant for that?

I use #define on it.

jamesatha · 2025-03-13T19:29:33Z

meta-facebook/minerva-ag/src/platform/plat_i2c_target.c

+void init_sensor_data_0_2_table()
+{
+	for (int reg_offset = 0; reg_offset < 4; reg_offset++) {
+		int num_idx = (PLAT_SENSOR_NUM_MAX - 1) - (50 * reg_offset);


similar question on the 50 here

I use #define on it.

facebook-github-bot · 2025-03-18T06:05:16Z

@LisaChang-Quanta has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot · 2025-03-18T06:33:26Z

@LisaChang-Quanta has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot · 2025-03-18T06:46:54Z

@LisaChang-Quanta has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot · 2025-03-24T14:12:43Z

@LisaChang-Quanta has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot · 2025-03-31T06:59:29Z

@LisaChang-Quanta has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot · 2025-03-31T08:41:46Z

@LisaChang-Quanta has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot · 2025-04-01T11:59:35Z

@LisaChang-Quanta has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot · 2025-04-02T02:59:47Z

@LisaChang-Quanta has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot · 2025-04-10T05:33:59Z

@LisaChang-Quanta has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot · 2025-04-10T05:37:40Z

@LisaChang-Quanta has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot · 2025-04-11T01:44:53Z

@LisaChang-Quanta has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot · 2025-04-16T02:40:10Z

@LisaChang-Quanta has updated the pull request. You must reimport the pull request before landing.

Prabha-Veerubhotla

@LisaChang-Quanta please fix failing checks and rebase

facebook-github-bot · 2025-04-22T01:29:31Z

@LisaChang-Quanta has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot · 2025-04-22T01:36:06Z

@LisaChang-Quanta has updated the pull request. You must reimport the pull request before landing.

Prabha-Veerubhotla

@LisaChang-Quanta one of the checks are still failing. Please fix.

Summary: - Support i2c telemetry command - Support reg: 0x00 ~ 0x05 - Support part of reg: 0x06 - Add comment on i2c_target_config: rd_data_collect_func Test Plan: - Build code: PASS

…ommand Summary: - Support fru product custom data - Support i2c telemetry write command - Support reg: 0x08 ~ 0x76 Test Plan: - Build code: PASS

Summary: - Support i2c telemetry i2c bridge master write/read command - Support reg: 0x40 ~ 0x42 Test Plan: - Build code: PASS

Summary: - Modify bootstrap default value - base on cpld version: 0070d010 - change: SOC_BOOT_SOURCE_0_4, S_OWL_BOOT_SOURCE_0_7, N_OWL_BOOT_SOURCE_0_7 Test Plan: - Build code: PASS

Summary: - Support telemetry control sensor polling command - Support reg: 0xF0 Test Plan: - Build code: PASS

facebook-github-bot · 2025-04-28T01:28:58Z

@LisaChang-Quanta has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot · 2025-04-30T18:02:51Z

This pull request has been merged in 63af749.

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 7, 2025

jamesatha requested changes Mar 13, 2025

View reviewed changes

LisaChang-Quanta force-pushed the minerva-ag/support_i2c_telemetry_command branch from f463798 to 065f5fe Compare March 18, 2025 06:05

LisaChang-Quanta force-pushed the minerva-ag/support_i2c_telemetry_command branch from 76eac5f to 19b97ad Compare March 18, 2025 06:46

LisaChang-Quanta force-pushed the minerva-ag/support_i2c_telemetry_command branch from 19b97ad to 941775f Compare March 24, 2025 14:12

LisaChang-Quanta changed the title ~~minerva-ag: Support i2c telemetry command~~ minerva-ag: Support i2c telemetry command and support fru product custom data and modify bootstrap command with setting hex-value Mar 24, 2025

LisaChang-Quanta force-pushed the minerva-ag/support_i2c_telemetry_command branch from 941775f to 38df263 Compare March 31, 2025 06:59

LisaChang-Quanta force-pushed the minerva-ag/support_i2c_telemetry_command branch from 38df263 to 46128dc Compare March 31, 2025 08:41

LisaChang-Quanta force-pushed the minerva-ag/support_i2c_telemetry_command branch from 46128dc to 1652cff Compare April 1, 2025 11:59

LisaChang-Quanta force-pushed the minerva-ag/support_i2c_telemetry_command branch from c5d8282 to 2e97c0a Compare April 10, 2025 05:33

LisaChang-Quanta force-pushed the minerva-ag/support_i2c_telemetry_command branch from 2e97c0a to b0e8906 Compare April 10, 2025 05:37

LisaChang-Quanta force-pushed the minerva-ag/support_i2c_telemetry_command branch from b0e8906 to 78044a9 Compare April 11, 2025 01:44

LisaChang-Quanta force-pushed the minerva-ag/support_i2c_telemetry_command branch from 78044a9 to 6fe2a0d Compare April 16, 2025 02:40

Prabha-Veerubhotla requested changes Apr 21, 2025

View reviewed changes

LisaChang-Quanta force-pushed the minerva-ag/support_i2c_telemetry_command branch from 6fe2a0d to 902cb7a Compare April 22, 2025 01:29

Prabha-Veerubhotla requested changes Apr 22, 2025

View reviewed changes

LisaChang-Quanta added 9 commits April 28, 2025 09:28

minerva-ag: Support i2c telemetry command

a70e3a4

Summary: - Support i2c telemetry command - Support reg: 0x00 ~ 0x05 - Support part of reg: 0x06 - Add comment on i2c_target_config: rd_data_collect_func Test Plan: - Build code: PASS

minerva-ag: Support fru product custom data and i2c telemetry write c…

a709052

…ommand Summary: - Support fru product custom data - Support i2c telemetry write command - Support reg: 0x08 ~ 0x76 Test Plan: - Build code: PASS

modify bootstrap command with setting hex-value

11a28a4

modify_telemetry_with_bootstrap_command

72374be

modify telemetry offset 0x08 format

0f790fb

modify set bootstrap to prevent out-of-range values

ceb46fd

minerva-ag: Support telemetry i2c bridge master write/read command

92b34b9

Summary: - Support i2c telemetry i2c bridge master write/read command - Support reg: 0x40 ~ 0x42 Test Plan: - Build code: PASS

minerva-ag: Modify bootstrap default value

d85f478

Summary: - Modify bootstrap default value - base on cpld version: 0070d010 - change: SOC_BOOT_SOURCE_0_4, S_OWL_BOOT_SOURCE_0_7, N_OWL_BOOT_SOURCE_0_7 Test Plan: - Build code: PASS

minerva-ag: Support telemetry control sensor polling command

073435d

Summary: - Support telemetry control sensor polling command - Support reg: 0xF0 Test Plan: - Build code: PASS

LisaChang-Quanta force-pushed the minerva-ag/support_i2c_telemetry_command branch from 5234cab to 073435d Compare April 28, 2025 01:28

facebook-github-bot closed this in 63af749 Apr 30, 2025

facebook-github-bot added the Merged label Apr 30, 2025

Comments

Conversation

LisaChang-Quanta commented Mar 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Mar 7, 2025

Uh oh!

jamesatha Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

jamesatha Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

jamesatha Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

jamesatha Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

LisaChang-Quanta Mar 25, 2025

Choose a reason for hiding this comment

Uh oh!

jamesatha Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

LisaChang-Quanta Mar 25, 2025

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Mar 18, 2025

Uh oh!

facebook-github-bot commented Mar 18, 2025

Uh oh!

facebook-github-bot commented Mar 18, 2025

Uh oh!

facebook-github-bot commented Mar 24, 2025

Uh oh!

facebook-github-bot commented Mar 31, 2025

Uh oh!

facebook-github-bot commented Mar 31, 2025

Uh oh!

facebook-github-bot commented Apr 1, 2025

Uh oh!

facebook-github-bot commented Apr 2, 2025

Uh oh!

facebook-github-bot commented Apr 10, 2025

Uh oh!

facebook-github-bot commented Apr 10, 2025

Uh oh!

facebook-github-bot commented Apr 11, 2025

Uh oh!

facebook-github-bot commented Apr 16, 2025

Uh oh!

Prabha-Veerubhotla left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Apr 22, 2025

Uh oh!

facebook-github-bot commented Apr 22, 2025

Uh oh!

Prabha-Veerubhotla left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Apr 28, 2025

Uh oh!

facebook-github-bot commented Apr 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

LisaChang-Quanta commented Mar 7, 2025 •

edited

Loading