Skip to content

Comments

minerva-ag: Modify blackbox cpld dump format and add more cpld polling registers#2279

Closed
Victor-Jhong wants to merge 1 commit intofacebook:mainfrom
Victor-Jhong:minerva-ag/modify_blackbox_cpld_dump_format
Closed

minerva-ag: Modify blackbox cpld dump format and add more cpld polling registers#2279
Victor-Jhong wants to merge 1 commit intofacebook:mainfrom
Victor-Jhong:minerva-ag/modify_blackbox_cpld_dump_format

Conversation

@Victor-Jhong
Copy link
Contributor

@Victor-Jhong Victor-Jhong commented Mar 20, 2025 •
edited
Loading

Summary:

  • Modify blackbox cpld dump format
  • Due to the length of blackbox log, we can't store the full cpld dump in one log, we remove the power sequence part at cpld dump
  • Add more cpld polling registers

Test Plan:

  • Build code: PASS

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 20, 2025
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 20, 2025

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. (Because this pull request was imported automatically, there will not be any future comments.)

@Victor-Jhong Victor-Jhong force-pushed the minerva-ag/modify_blackbox_cpld_dump_format branch from d7f32c3 to 38d273a Compare March 20, 2025 12:36
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 20, 2025

@Victor-Jhong has updated the pull request. You must reimport the pull request before landing.

@Victor-Jhong Victor-Jhong force-pushed the minerva-ag/modify_blackbox_cpld_dump_format branch from 38d273a to 57ddf88 Compare March 20, 2025 12:45
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 20, 2025

@Victor-Jhong has updated the pull request. You must reimport the pull request before landing.

@Victor-Jhong Victor-Jhong force-pushed the minerva-ag/modify_blackbox_cpld_dump_format branch 2 times, most recently from 64e0f6b to f0cfe03 Compare March 20, 2025 14:14
@Victor-Jhong Victor-Jhong changed the title minerva-ag: Modify blackbox cpld dump format minerva-ag: Modify blackbox cpld dump format and add more cpld polling registers Mar 20, 2025
@Victor-Jhong Victor-Jhong force-pushed the minerva-ag/modify_blackbox_cpld_dump_format branch from f0cfe03 to d792a67 Compare March 20, 2025 14:32
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 20, 2025

@Victor-Jhong has updated the pull request. You must reimport the pull request before landing.

@Victor-Jhong Victor-Jhong force-pushed the minerva-ag/modify_blackbox_cpld_dump_format branch from d792a67 to aee5adf Compare March 21, 2025 02:41
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 21, 2025

@Victor-Jhong has updated the pull request. You must reimport the pull request before landing.

@Victor-Jhong Victor-Jhong reopened this Mar 21, 2025
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 21, 2025

@Victor-Jhong has updated the pull request. You must reimport the pull request before landing.

@Victor-Jhong Victor-Jhong force-pushed the minerva-ag/modify_blackbox_cpld_dump_format branch from 5f9d4c1 to f3e894a Compare March 21, 2025 04:56
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 21, 2025

@Victor-Jhong has updated the pull request. You must reimport the pull request before landing.

@Victor-Jhong Victor-Jhong force-pushed the minerva-ag/modify_blackbox_cpld_dump_format branch from f3e894a to 1d7c842 Compare March 24, 2025 06:32
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 24, 2025

@Victor-Jhong has updated the pull request. You must reimport the pull request before landing.

wangx6f
wangx6f requested changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@wangx6f wangx6f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please take care of the cpp check error as well as the clang format error?

@Victor-Jhong Victor-Jhong force-pushed the minerva-ag/modify_blackbox_cpld_dump_format branch from 1d7c842 to 9afbbbf Compare April 1, 2025 12:31
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 1, 2025

@Victor-Jhong has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 8, 2025

This pull request has been merged in 30d7923.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wangx6f wangx6f wangx6f requested changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Victor-Jhong @facebook-github-bot @wangx6f