Skip to content

deb file was not in most recent release assets#306

Merged
pcottle merged 1 commit into
facebook:masterfrom
markstos:patch-1
Aug 30, 2019
Merged

deb file was not in most recent release assets#306
pcottle merged 1 commit into
facebook:masterfrom
markstos:patch-1

Conversation

@markstos
Copy link
Copy Markdown

Update README to reflect that building locally needs to be done on debian-based Linux systems

Update README to reflect that building locally needs to be done on debian-based Linux systems
@facebook-github-bot
Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@markstos
Copy link
Copy Markdown
Author

Actually, the last line of the Debian manual instructions is just wrong: ls ../fpp_0.7.2_noarch.deb. That will only list the file, and the wrong version at that. A correct install command would be sudo dpkg -i ../fpp*.deb

@pcottle
Copy link
Copy Markdown
Contributor

pcottle commented Aug 30, 2019

Thanks for the fix! Yeah I was never able to get the debian build locally myself, I think deferring to local build is the right call

@pcottle pcottle merged commit d3d1109 into facebook:master Aug 30, 2019
@markstos
Copy link
Copy Markdown
Author

I just tested the local build option and it worked fine (On Debian 8).

@markstos markstos deleted the patch-1 branch August 30, 2019 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants