Fix race condition in SoLoader#init.#99
Closed
mhrheaume wants to merge 1 commit into
Closed
Conversation
If two threads call `SoLoader#init` at the same time, there is a chance they both try to initialize `sSoSources` one after the other, which eventually leads to an `OverlappingFileLockException`. To fix this issue, add a double check after obtaining the write lock to only initialize if `sSoSources` is still null. Fixes #93.
|
@passy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Jun 30, 2022
Summary: **Feature** Support pre-computing the dependency **Fixes** Wrongly loaded directApkLdPath(facebook/SoLoader#104) SoLoader causes crashes on migration to an Android 12 device(facebook/SoLoader#100, facebook/SoLoader#88 ) Fix race condition in SoLoader#init(facebook/SoLoader#99) **Full Changelog**: facebook/SoLoader@v0.10.3...v0.10.4 Reviewed By: charles011 Differential Revision: D37525875 fbshipit-source-id: a64e4021012128fe4a78d3ec9e955dae2ae35926
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If two threads call
SoLoader#initat the same time, there is a chancethey both try to initialize
sSoSourcesone after the other, whicheventually leads to an
OverlappingFileLockException.To fix this issue, add a double check after obtaining the write lock to
only initialize if
sSoSourcesis still null.Fixes #93.