Conversation
…nization Pygments 2.20 emits the inter-token space before an underlined identifier as its own Whitespace token, wrapping it in default-color ANSI codes (\x1b[37m \x1b[39;49;00m). Update the expected literal accordingly.
typeguard 4.x renders typing.List[str] as list[str] in error messages. Update assertRaisesRegex pattern in raises_TypeCheckError_when_returning_coroutine_instance to match.
Allows `pytest pytest-testslide/tests` to run from the repo root without needing to pre-set PYTHONPATH. Previously only the Makefile's pytest_tests target worked, since it exported PYTHONPATH=pytest-testslide:. — the bare command failed because the inner pytester run could not import pytest_testslide or testslide (neither is installed in the venv; both are sourced in-tree).
mypy cannot narrow Union[Mock, StrictMock] through isinstance against a runtime-looked-up class (mock_class comes from MOCK_TEMPLATE_EXTRACTORS iteration), so the call to extract_mock_template was rejected. Add an explicit cast to express what the isinstance check guarantees.
- Drop unused `import sys` from testslide/bdd/lib.py and testslide/core/__init__.py (F401). - Suppress F824 on `global` statements in mock_callable.py that declare names which are read but not assigned in scope. Collapsed multi-line global declarations onto one line so the noqa comment can be attached.
Bump pytest requirement to >=9.0.3
meta-cla
Bot
added
the
CLA Signed
Coverage Report for CI Build 25010161216Warning No base build found for commit Coverage: 92.17%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
|
@oxo42 has imported this pull request. If you are a Meta employee, you can view this in D102792375. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate that CI passes