fix(docsite): remove duplicate playground key in Skeleton doc#3197
Merged
Conversation
Skeleton.doc.mjs declared the playground key twice, failing the typecheck:docs gate (TS1117) and blocking the build job on every open PR. Keep the later block (the effective one) and drop the dead earlier duplicate; no change to the rendered properties-tab preview.
cixzhang
requested review from
ejhammond,
imdreamrunner,
josephfarina,
marie-lucas,
nynexman4464 and
thedjpetersen
as code owners
meta-cla
Bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
🚀 Vercel Preview Deployment
|
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR No new or modified components detected. Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
thedjpetersen
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
packages/core/src/Skeleton/Skeleton.doc.mjsdeclares theplaygroundkey twice in thedocsobject. This fails thetypecheck:docsgate with:Because the
buildjob runstypecheck:docsagainst the PR-merged-with-maintree, this breaks the build check on every open PR, not just one. (main's own push only runstest, so the duplicate landed without thebuildgate catching it.)The two blocks came from two separate fixes for the same Skeleton properties-tab preview issue — one added a
playgroundblock afterkeywords, the other afterprops. In JS, the later key wins, so the first block was already dead.Fix
Remove the dead earlier
playgroundblock and keep the later one (the effective320 × 80preview). No change to the rendered properties-tab preview.Verification
pnpm -F @astryxdesign/core typecheck:docs→ passes (was TS1117).pnpm lint,sync-exports --check,generate-token-docs --check,check-changesets→ all clean.