fix(layer): guard entry animations with prefers-reduced-motion (infra-6)#3414
Draft
cixzhang wants to merge 1 commit into
Draft
fix(layer): guard entry animations with prefers-reduced-motion (infra-6)#3414cixzhang wants to merge 1 commit into
cixzhang wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR No new or modified components detected. Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the accessibility & keyboard-management program (#3343). Fixes finding
infra-6.Problem
The shared popover/layer entry animations —
Layer/layerAnimations.stylex.ts(translate + scale keyframes used by DropdownMenu, Popover, HoverCard, Tooltip, Selector and other layer surfaces) and theuseEntryAnimationpresets (slideDown/slideUp/fadeIn/scaleIn) — had noprefers-reduced-motionguard, unlike the ~20 individual components that do guard their motion. Users who ask for reduced motion still got sliding/scaling overlays.Fix
Each animation now disables its keyframe under
@media (prefers-reduced-motion: reduce)by settinganimationName: 'none'in that media query (StyleX conditional value). The layer simply appears instead of translating/scaling in. No change for users without the preference.Verification
Typecheck, lint, and the StyleX babel build all pass; DropdownMenu/Popover/Tooltip/HoverCard suites green (76 tests). Pure styling change (no behavior/test changes needed in the consumers).