Skip to content

Nicely handle errors when processing requests#333

Merged
qdeslandes merged 1 commit intofacebook:mainfrom
qdeslandes:daemon_survive_error
Sep 22, 2025
Merged

Nicely handle errors when processing requests#333
qdeslandes merged 1 commit intofacebook:mainfrom
qdeslandes:daemon_survive_error

Conversation

@qdeslandes
Copy link
Contributor

If a failure occurs during request processing, the daemon should print an error message and process the next request. It should not be possible to put the daemon in a failure state from a failing request, so there is no reason for the daemon to stop.

If a failure occurs during request processing, the daemon should print
an error message and process the next request. It should not be possible
to put the daemon in a failure state from a failing request, so there is
no reason for the daemon to stop.
@meta-cla meta-cla bot added the cla signed label Sep 22, 2025
@qdeslandes qdeslandes requested a review from Copilot September 22, 2025 08:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors error handling in the daemon's main loop to prevent individual request failures from terminating the entire daemon process. Instead of returning early on errors, the daemon now logs errors and continues processing subsequent requests.

  • Replaced early returns with continue statements for error conditions
  • Changed error logging levels from warnings to errors for some failure cases
  • Updated error messages to clarify that requests are being ignored rather than causing daemon shutdown

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@qdeslandes qdeslandes merged commit b6660df into facebook:main Sep 22, 2025
27 checks passed
@qdeslandes qdeslandes deleted the daemon_survive_error branch September 22, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments