Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
ReviewStack: https://reviewstack.dev/facebook/bpfilter/pull/366
ctest --test-dir build -R e2e.daemon.netns_to_hostwas flaky, which was annoying me, as it was failing on unrelated changes.With some Claude-assisted debugging, I found out it's because
uint8_t logsometimes contains garbage data, that we later OR into inlog |= BF_FLAG(header);line. When that happens, the printed output doesn't match whatawkis expecting.