tools: claude: use new review prompt to catch more issues#490
Merged
qdeslandes merged 1 commit intofacebook:mainfrom Mar 26, 2026
Merged
tools: claude: use new review prompt to catch more issues#490qdeslandes merged 1 commit intofacebook:mainfrom
qdeslandes merged 1 commit intofacebook:mainfrom
Conversation
Claude review of PR #490 (4a027ab)Nits
Clean PR overall. YAML syntax is correct, |
qdeslandes
approved these changes
Mar 26, 2026
Contributor
qdeslandes
left a comment
There was a problem hiding this comment.
Thanks! Looking forward to try this out!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like telling AI to do more work makes it do more work. (And costs more money.) Shocked Pikachu.
Tested on #489 using my local testing scripts (pzmarzly/claude-pr-review#test/):
cache_dirPOST field flows intoshutil.rmtree(bfoptimize-web:119)git reset --hardsilently destroys uncommitted work (bfoptimize:542)bypassPermissionsgives Claude agent unrestricted Bash (bfoptimize:259)NO_TESTSoption description is stale, now also disables benchmarks (CMakeLists.txt:33)NO_TESTSdoc description should mention benchmarks (build.rst:98)model/effortstring fields (bfoptimize-web:48)daemon: cgen:commit prefix is stale — daemon was removed from project (bfoptimize:249)-DNO_TESTS=1contradictsmake unit e2e integration— test targets won't exist (bfoptimize:246)results.html.j2deleted instead of moved —bfbencher history --report-pathbroken at runtime (bfbencher:39)DELETE /historycrashes withFileNotFoundErrorif cache dir doesn't exist yet (bfoptimize-web:180)--fail-on-benchmark-errordead code forhistorysubcommand (bfbencher:1298)find_package(benchmark REQUIRED)now runs without benchmark dep (ci.yaml:85)git commit -amstages all tracked files, not justCGEN_DIR/(bfoptimize:249)bfoptimize:238)And checked if workflow still works in: pzmarzly/claude-pr-review#16