build: add iwyu to docker files#506
Merged
qdeslandes merged 1 commit intofacebook:mainfrom Apr 15, 2026
Merged
Conversation
Author
|
I need to land this before being able to do this: #500 |
qdeslandes
requested changes
Apr 15, 2026
Contributor
qdeslandes
left a comment
qdeslandes
left a comment
There was a problem hiding this comment.
Could you add it to other Dockerfiles too? We often use the Dockerfile as source of truth for the dependencies required on a specific system.
jordalgo
changed the title
Author
|
Done. |
qdeslandes
requested changes
Apr 15, 2026
Contributor
qdeslandes
left a comment
qdeslandes
left a comment
There was a problem hiding this comment.
On Ubuntu, the package is iwyu.
Author
I gotta stop trusting Gemini. |
This will be needed when we switch to requiring iwyu as a Cmake dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be needed when we switch to requiring iwyu as a Cmake dependency.