Open
Conversation
meta-cla
bot
added
the
CLA Signed
Contributor
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D92785802. (Because this pull request was imported automatically, there will not be any future comments.) |
- Rename action to bxl.Action so it is findable in docs (I don't know if that was what was preventing docs generation, but it's worth a try!) - Add a method to get the output artifacts for an action in bxl. This allows selectively rebuilding the action by ensuring those outputs. I added a test, but I have no way to run those besides www.metacareers.com: facebook#1027 This is part of making action graph debugging slightly easier, which I want to prototype by writing some rather nasty BXLs: facebook#1217 Unfortunately I *think* there's no way to get the dependencies after the fact, since I *just* have a RegisteredAction. I believe that I can probably do something very bad with owner() then rerunning the analysis to get deps though.
lf-
force-pushed
the
jade/push-kvpoorkyzwku
branch
from
2d859d2 to
958658b
Compare
This was referenced Feb 23, 2026
josephsumabat
added a commit
to MercuryTechnologies/buck2
that referenced
this pull request
Mar 11, 2026
…r action debugging. facebook#1227
Nero5023
reviewed
Mar 19, 2026
| .action() | ||
| .outputs() | ||
| .iter() | ||
| .map(|a| StarlarkArtifact::new(Artifact::from(a.clone()))) |
Contributor
There was a problem hiding this comment.
Here we can use a.dupe().
Nero5023
reviewed
Mar 19, 2026
| action = ctx.audit().output(buck_out) | ||
|
|
||
| asserts.equals(action.owner(), target.label) | ||
| asserts.equals(actions.outputs()[0].basename, "with_output.txt") |
Contributor
There was a problem hiding this comment.
Here is a typo, should be action not actions
Contributor
|
Hey, thank you for the PR! Overall lgtm! Only twos nit I commented above, could you resolve those and do a rebase? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a test, but I have no way to run those besides www.metacareers.com: #1027
This is part of making action graph debugging slightly easier, which I want to prototype by writing some rather nasty BXLs: #1217
Unfortunately I think there's no way to get the dependencies after the fact, since I just have a RegisteredAction. I believe that I can probably do something very bad with owner() then rerunning the analysis to get deps though.