Skip to content

Fix build with cargo#1262

Closed
anubhavp28 wants to merge 1 commit intofacebook:mainfrom
anubhavp28:fix-cargo-build
Closed

Fix build with cargo#1262
anubhavp28 wants to merge 1 commit intofacebook:mainfrom
anubhavp28:fix-cargo-build

Conversation

@anubhavp28
Copy link

Feature pagable of starlark_map crate was renamed to pagable_dep

Summary:
feature `pagable` of `starlark_map` crate was renamed to `pagable_dep`
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 1, 2026
@meta-codesync
Copy link
Contributor

meta-codesync bot commented Mar 1, 2026

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D94809016. (Because this pull request was imported automatically, there will not be any future comments.)

@avdv
Copy link
Contributor

avdv commented Mar 3, 2026

FYI, this was fixed on main.

@bvinc
Copy link
Contributor

bvinc commented Mar 5, 2026

This could still use some fixing in main.

host_sharing/Cargo.toml
15:starlark_map = { workspace = true, features = ["pagable"] }

app/buck2_bxl/Cargo.toml
32:starlark_map = { workspace = true, features = ["pagable"] }

@IanChilds IanChilds closed this Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants