-
Notifications
You must be signed in to change notification settings - Fork 322
rust-project: add support for alternative Buck2 commands #774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
WDYT @davidbarsky? |
Contributor
Author
|
The CI failure looks completely unrelated :/ |
Contributor
|
@davidbarsky has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
7a2b350 to
7206804
Compare
Contributor
|
@davidbarsky has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This is useful for users of wrappers such as Buckle, as well as developers hacking on Buck2 that need to use a custom build.
7206804 to
bd6d0e1
Compare
Contributor
Author
|
@davidbarsky This patch still isn't available in master, has it been lost in the gh/meta sync or something? |
thoughtpolice
added a commit
to thoughtpolice/buck2
that referenced
this pull request
May 28, 2025
Refile of facebook#774, which got lost somewhere in the covers. This is needed so that you can e.g. configure your editor to use the `rust-project` dotslash file, which then needs the `buck2` dotslash file. Co-authored-by: Cedric Barreteau <cbarreteau@tower-research.com> Signed-off-by: Cedric Barreteau <cbarreteau@tower-research.com> Signed-off-by: Austin Seipp <aseipp@pobox.com>
thoughtpolice
added a commit
to thoughtpolice/buck2
that referenced
this pull request
May 28, 2025
Refile of facebook#774, which got lost somewhere in the covers. This is needed so that you can e.g. configure your editor to use the `rust-project` dotslash file, which then needs the `buck2` dotslash file. Co-authored-by: Cedric Barreteau <cbarreteau@tower-research.com> Signed-off-by: Cedric Barreteau <cbarreteau@tower-research.com> Signed-off-by: Austin Seipp <aseipp@pobox.com>
facebook-github-bot
pushed a commit
that referenced
this pull request
May 29, 2025
Summary: Refile of #774, which got lost somewhere in the covers. This is needed so that you can e.g. configure your editor to use the `rust-project` dotslash file, which then needs the `buck2` dotslash file. Pull Request resolved: #972 Reviewed By: davidbarsky Differential Revision: D75550377 Pulled By: darichey fbshipit-source-id: 38b95dc1a305668d4c00e7f4b58f4dd4bdf75956
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
rust-project
Rust Project Tool
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for users of wrappers such as Buckle, as well as developers hacking on Buck2 that need to use a custom build.