extract SimpleDirEntry into dice/dice so that we can use it in UserDataComputation #888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…taComputation Summary: We want to do per-computation cache of readdirs so that when we introduce a new key for tracking packages we dont call read_dir twice. this diff is preparatory work for the next one where we had to move around some definitions to avoid cycles Differential Revision: D72246720
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72246720 |
Contributor
|
Closing, as I believe we took an alternative approach so this isn't needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We want to do per-computation cache of readdirs so that when we introduce a new key for tracking packages we dont call read_dir twice.
this diff is preparatory work for the next one where we had to move around some definitions to avoid cycles
Differential Revision: D72246720