Use textContent instead of innerHTML when assigning script#12089
Open
shhnjk wants to merge 1 commit intofacebook:mainfrom
Open
Use textContent instead of innerHTML when assigning script#12089shhnjk wants to merge 1 commit intofacebook:mainfrom
shhnjk wants to merge 1 commit intofacebook:mainfrom
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
packages/react-error-overlay/src/index.jshas a code where script is assigned usinginnerHTML.This causes a problem in document under Trusted Types enforcement, because assignment to
innerHTMLrequiresTrustedHTML, but resulting html will be treated as script and therefore requiresTrustedScript.This change modifies script assignment using
textContentwhich wouldn't requireTrustedHTML, and thereforeTrustedScriptcan be assigned (through default policy in Trusted Types).Note: further change would be required if this library wants to be compatible with Trusted Types. However, this change only aims to allow this library to operate using default policy (which is not ideal but just a work around).