Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix shortcut handling in react-error-overlay #2238
In regard to #2231, I tried to write a quick fix for the error, by not handling shortcuts if the error list is empty.
Tested by rebuilding
If you think they're is a better way to do this, i'm completely open for suggestions, as I am new to create-react-app codebase !
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at firstname.lastname@example.org. Thanks!
If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact email@example.com if you have any questions.