Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Improve README phrasing #1799
I am not a create-react-app user, nor even a React user, but having been encouraged by @gaearon to improve the communication in the Readme, I am sending my purely editorial PR to this repo. Two changes:
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at email@example.com. Thanks!
If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact firstname.lastname@example.org if you have any questions.
Just great! The intention of my PR was just to indicate the type of change rather than be precise in my wording (as we agreed on twitter). So yes - good to go!…
On Sat, 11 Mar 2017, 22:55 Dan Abramov, ***@***.***> wrote: What do you think about this phrasing instead? [image: screen shot 2017-03-11 at 9 55 02 pm] <https://cloud.githubusercontent.com/assets/810438/23827179/70165738-06a5-11e7-8b38-245de7283740.png> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1799 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AApn5O-tttg07fkQC_fCFFm8yaqCOiDLks5rkxhkgaJpZM4MaWKX> .