Skip to content

Conversation

@lepture
Copy link

@lepture lepture commented Nov 1, 2018

Related issues:

  1. Add more entry points #1084
  2. Support index.web.js entry file #3941
  3. Support index.jsx entry file #3052

With this change, you can build different bundles via:

ENTRY_POINT=src/admin react-scripts build
ENTRY_POINT=src/shop react-scripts build
ENTRY_POINT=src/blog react-scripts build

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@wwilsman
Copy link

wwilsman commented Nov 1, 2018

This is exactly what we need to get CRA working with acceptance testing. We need a way to bundle the tests using the same bundler that bundles the app. Currently there is no way to do that in CRA without ejecting which is not very ideal.

@stale
Copy link

stale bot commented Dec 1, 2018

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Dec 1, 2018
@lepture
Copy link
Author

lepture commented Dec 2, 2018

? No activity?

@stale stale bot removed the stale label Dec 2, 2018
@stale
Copy link

stale bot commented Jan 1, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Jan 1, 2019
@stale
Copy link

stale bot commented Jan 6, 2019

This pull request has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue. Thank you for your contribution!

@stale stale bot closed this Jan 6, 2019
@lepture
Copy link
Author

lepture commented Jan 7, 2019

WTF.

@lock lock bot locked and limited conversation to collaborators Jan 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants