Skip to content

Comments

Add a link to aws-spa#7198

Open
nicgirault wants to merge 1 commit intofacebook:mainfrom
nicgirault:patch-1
Open

Add a link to aws-spa#7198
nicgirault wants to merge 1 commit intofacebook:mainfrom
nicgirault:patch-1

Conversation

@nicgirault
Copy link

No description provided.

@nicgirault nicgirault requested review from amyrlam and iansu as code owners June 11, 2019 06:54
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@nicgirault
Copy link
Author

@iansu & @amyrlam: can I do anything to make the review easier to you?

@nicgirault
Copy link
Author

nicgirault commented Nov 4, 2019

@amyrlam could you tell me what I can do so that adding this lib to the doc is considered? I would perfectly understand that you don't want the doc to link to some random library. aws-spa is used in production in my company and in several other companies in Paris. It makes it very easy to deploy a SPA following CRA recommendations.

Let me know if this is not OK to add this link. Otherwise, how can I help you review the change?

@nicgirault
Copy link
Author

@iansu any chance you help me to understand what to do?

@amyrlam amyrlam removed their request for review August 24, 2020 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants