Skip to content

Update babel core to 7.7.0 and typescript to 3.7 #7928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adwd wants to merge 4 commits into from
Closed

Update babel core to 7.7.0 and typescript to 3.7 #7928

adwd wants to merge 4 commits into from

Conversation

@adwd
Copy link

@adwd adwd commented Nov 5, 2019 •
edited
Loading

babel 7.7.0 is released (and I want to use TypeScript 3.7 features)
https://babeljs.io/blog/2019/11/05/7.7.0

@facebook-github-bot
Copy link

facebook-github-bot commented Nov 5, 2019

Hi adwd! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

facebook-github-bot commented Nov 5, 2019

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@adwd
Copy link
Author

adwd commented Nov 5, 2019

test fails due to this issue typescript-eslint/typescript-eslint#1138

andriijas
andriijas suggested changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@andriijas andriijas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission!

While we wait for typescript 3.7.0 final release - can you update the PR to update babel in all packages?

Thanks

@andriijas andriijas added this to the 3.3 milestone Nov 5, 2019
@andriijas andriijas changed the title Update babel core Update babel core to 7.7.0 and typescript to 3.7 Nov 5, 2019
@andriijas
Copy link
Contributor

andriijas commented Nov 6, 2019

Thanks @adwd - we are now waiting for a new prettier release as mentioned in #7438

@ericchernuka
Copy link

ericchernuka commented Nov 9, 2019 •
edited
Loading

Looks like Prettier was updated to 1.19.1 last night to support Typescript 3.7. Details

@ianschmitz
Copy link
Contributor

ianschmitz commented Nov 9, 2019

Hi thanks for the PR. We upgraded these packages in another PR so I'm going to close this one.

@ianschmitz ianschmitz closed this Nov 9, 2019
@adwd adwd deleted the update-babel-core branch November 10, 2019 01:38
@lock lock bot locked and limited conversation to collaborators Nov 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ianschmitz ianschmitz Awaiting requested review from ianschmitz

@iansu iansu Awaiting requested review from iansu

@mrmckeb mrmckeb Awaiting requested review from mrmckeb

@petetnt petetnt Awaiting requested review from petetnt

1 more reviewer

@andriijas andriijas andriijas requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

3.3

Development

Successfully merging this pull request may close these issues.

5 participants

@adwd @facebook-github-bot @andriijas @ericchernuka @ianschmitz