[question] postStart implementation

[gabrielcsapo]

Hello,

Is there work being done to implement this? We want to add local search functionality that doesn't require a full build in https://github.com/gabrielcsapo/docusaurus-plugin-search-local.

Thank you,
Gabriel Csapo

[slorber]

No work is being done on this but we could add it.

Can you detail the use-case?

When should such a lifecycle hook be called exactly and with which params/data?

II can think of 2 places:

  devServer.listen(port, host, (err) => {
    // ...
  });

compiler.hooks.done.tap('done', (stats) => {
  // ...
});

[gabrielcsapo]

thoughts on this @slorber ?

[slorber]

These seem like the right places in my opinion.

Those are 2 different places, so we'll need to figure out which one of the 2 should trigger the lifecycle event 🤪

After Webpack compilation looks better to me, similarly to postBuild. But the Webpack compilation only happens after a HTTP request, so maybe it can be a problem?

postRebuild

Couldn't this be a boolean param in postStart?

In terms of the parameters, it should be the same as postBuild to keep the interface the same.

Maybe then having postCompile after any webpack dev/prod compilation be a better lifecycle hook?

[gabrielcsapo]

I think postCompile would be a good hook, it is more verbose in what it actually means instead of postStart which is sort of confusing.

postCompile(rebuild: boolean)

[gabrielcsapo]

I created a PR with initial work that handles the postCompile hook case @slorber

[slorber]

Just linking, as it's not automatic on GH discussions: PR is #7737