Fixes for android 24 emulator#476
Conversation
sas
left a comment
sas
left a comment
There was a problem hiding this comment.
The change is fine if you re-add the quotes. Feel free to fix and submit without another review.
|
|
||
| # This is required due to dependency issues in the sdk. Hopefully this can be removed in future | ||
| # versions of the sdk. | ||
| if [ "${api_level}" -gt 23 ]; then |
There was a problem hiding this comment.
I'm not sure you should remove these quotes. If the argument is actually a numeric argument, it won't make a difference, but if the argument is not (error case), the quotes will prevent [ from failing with stupid errors.
There was a problem hiding this comment.
I'm pretty sure this didn't work with the quotes.
There was a problem hiding this comment.
I'm pretty sure language-wise it'll make no difference unless ${api_level} contains something with spaces.
There was a problem hiding this comment.
The language spec says you're right. I'll double check that it works tomorrow.
| case "${TARGET}" in | ||
| "Android-ARM") emulator_arch="arm";; | ||
| "Android-ARM64") emulator_arch="aarch64";; | ||
| "Android-ARM64") emulator_arch="ranchu-arm64";; |
There was a problem hiding this comment.
This is a little bit pathetic :D
There was a problem hiding this comment.
Ranchu is the machine type used when invoking qemu-android-aarch64 or whatever it's called. I wish it was just emulator64-arm64 as -machine type=ranchu is already the default. I guess they wanted to make that extra clear. Including it in the name of the emulator binary feels strange. :/
bulbazord
left a comment
bulbazord
left a comment
There was a problem hiding this comment.
I don't know if I would say this "fixes" the android 24 emulator, but these changes are without a doubt necessary for when the emulator isn't totally broken.
Looks good to me! :D
| case "${TARGET}" in | ||
| "Android-ARM") emulator_arch="arm";; | ||
| "Android-ARM64") emulator_arch="aarch64";; | ||
| "Android-ARM64") emulator_arch="ranchu-arm64";; |
There was a problem hiding this comment.
Ranchu is the machine type used when invoking qemu-android-aarch64 or whatever it's called. I wish it was just emulator64-arm64 as -machine type=ranchu is already the default. I guess they wanted to make that extra clear. Including it in the name of the emulator binary feels strange. :/
4 participants
No description provided.