Skip to content

Fix TimeseriesExporter duration_cast namespace issue#72

Closed
envolution wants to merge 1 commit intofacebook:mainfrom
envolution:fix-duration-cast
Closed

Fix TimeseriesExporter duration_cast namespace issue#72
envolution wants to merge 1 commit intofacebook:mainfrom
envolution:fix-duration-cast

Conversation

@envolution
Copy link
Contributor

fixes the following compilation errors in edencommon

[ 71%] Building CXX object eden/common/utils/test/CMakeFiles/utils_test.dir/ImmediateFutureTest.cpp.o
In file included from /usr/include/fb303/ThreadLocalStats-inl.h:21,
                 from /usr/include/fb303/ThreadLocalStats.h:959,
                 from /usr/include/fb303/ThreadLocalStatsMap.h:21,
                 from /usr/include/fb303/ThreadCachedServiceData.h:34,
                 from /usr/include/fb303/detail/QuantileStatWrappers.h:24,
                 from /home/builder/pkg_builds/build-edencommon-b317d57b/src/edencommon-2025.09.22.00/eden/common/telemetry/StatsGroup.h:12,
                 from /home/builder/pkg_builds/build-edencommon-b317d57b/src/edencommon-2025.09.22.00/eden/common/telemetry/StatsGroup.cpp:8:
/usr/include/fb303/TimeseriesExporter.h: In static member function ‘static void facebook::fb303::TimeseriesExporter::getCounterName(char*, int, const MLTS*, folly::StringPiece, facebook::fb303::ExportType, int)’:
/usr/include/fb303/TimeseriesExporter.h:98:27: error: ‘duration_cast’ was not declared in this scope; did you mean ‘std::chrono::duration_cast’? [-Wtemplate-body]
   98 |       auto durationSecs = duration_cast<std::chrono::seconds>(duration);
      |                           ^~~~~~~~~~~~~
      |                           std::chrono::duration_cast
In file included from /usr/include/c++/15.2.1/chrono:45,
                 from /usr/include/fb303/detail/QuantileStatWrappers.h:19:
/usr/include/c++/15.2.1/bits/chrono.h:279:7: note: ‘std::chrono::duration_cast’ declared here
  279 |       duration_cast(const duration<_Rep, _Period>& __d)
      |       ^~~~~~~~~~~~~
/usr/include/fb303/TimeseriesExporter.h:98:61: error: expected primary-expression before ‘>’ token [-Wtemplate-body]
   98 |       auto durationSecs = duration_cast<std::chrono::seconds>(duration);
      |                                                             ^
In file included from /usr/include/fb303/SimpleLRUMap.h:24,
                 from /usr/include/fb303/ThreadCachedServiceData.h:33:
/usr/include/fb303/TimeseriesExporter.h:99:7: error: expected ‘(’ before ‘>’ token [-Wtemplate-body]
   99 |       DCHECK(duration_cast<typename MLTS::Duration>(durationSecs) == duration);
      |       ^~~~~~
      ```

@meta-cla meta-cla bot added the CLA Signed label Sep 22, 2025
@facebook-github-bot
Copy link
Contributor

@praihan has imported this pull request. If you are a Meta employee, you can view this in D83005371.

@facebook-github-bot
Copy link
Contributor

@praihan merged this pull request in 66a0741.

@envolution envolution deleted the fix-duration-cast branch September 23, 2025 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants