[Nexthop] Simplify and improve PlatformManager documentation#1078
Open
marif-nexthop wants to merge 2 commits intofacebook:mainfrom
Open
[Nexthop] Simplify and improve PlatformManager documentation#1078marif-nexthop wants to merge 2 commits intofacebook:mainfrom
marif-nexthop wants to merge 2 commits intofacebook:mainfrom
Conversation
Signed-off-by: marif-nexthop <marif@nexthop.ai>
Scott8440
approved these changes
Apr 24, 2026
Contributor
Scott8440
left a comment
There was a problem hiding this comment.
Thanks for doing this!
|
|
||
| PMUnit presence bits must be managed by the chips present in the parent PMUnit. | ||
|
|
||
| ### Presence Detection |
Contributor
There was a problem hiding this comment.
You could link to the thrift struct for presence detection here
Contributor
Author
There was a problem hiding this comment.
done in the latest diff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
This PR streamlines the PlatformManager documentation by reducing redundant content, improving readability, and pointing readers toward source code where appropriate. The previous PR in this series was #943.
modeling.mdand removed the separate page.--help- Removed the manually maintained list of PlatformManager arguments in favor of a pointer to--help, ensuring docs don't go stale.Test Plan
Deployed a local
docusaurusinstance with the new documentation and verified that changes look as expected.