fan_service: Adapt to fan LED is controlled by hardware #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QiuyunXie
force-pushed
the
minerva_remove_fanled
branch
from
6e61209 to
6dc3842
Compare
Contributor
|
@mikechoifb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@mikechoifb merged this pull request in da8b57c. |
marif-nexthop
added a commit
to nexthop-ai/fboss
that referenced
this pull request
Dec 31, 2025
…o FBOSS image (facebook#243) <!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. --> **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` We noticed that the management interface name on `wdg101` after PXE booting one of our FBOSS distro images changed to `eno1`. The Accton SW has it as `eth0` which is the default in some FBOSS tests too. I looked at the difference and found that in our FBOSS distro image we are not passing `biosdevname=0 net.ifnames=0` kernel commandline args while Accton's linux image is passing it. These two kernel arguments are used to disable `Predictable Network Interface Naming` which names interfaces like `eno1`. <!-- Explain the motivation for making this change and any other context that you think would help reviewers of your code. What existing problem does the pull request solve? --> <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. How exactly did you verify that your PR solves the issue you wanted to solve? --> <!-- If a relevant Github issue exists for this PR, please make sure you link that issue to this PR --> Tested by modifying kernel commandline args on Wedge800 (`wdg101`) and verifying that the interface is listed at `eth0` and not `eno1`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For Minerva project, the FAN LEDs are controlled by FAN CPLD and compute blades do not participate in the control of the FAN LEDs. So "ledSysfsPath" entry can be empty. When "ledSysfsPath" is empty, no need to control the FAN LED.
Test log
Attach the detailed log:
Tahan_remove_fanLED_log.txt