Skip to content

Comments

DARWIN: update led_manager.json#269

Closed
adamcalabrigo wants to merge 4 commits intofacebook:mainfrom
adamcalabrigo:darwin_led_manager_update
Closed

DARWIN: update led_manager.json#269
adamcalabrigo wants to merge 4 commits intofacebook:mainfrom
adamcalabrigo:darwin_led_manager_update

Conversation

@adamcalabrigo
Copy link
Contributor

Description

Updates led_manager.json config for DARWIN platform with two changes:

  1. Updates LED sysfs files to account for refactored kernel driver.
  2. Adds Rackmon fan as fan6.

Test Plan

Tested on Darwin with Linux kernel 6.4 and CentOS 9.

data_corral_service initializes LEDs correctly:

I1015 02:00:45.049965 10377 PlatformNameLib.cpp:71] Platform name read from cache: DARWIN
I1015 02:00:45.050030 10377 ConfigLib.cpp:48] Using config file: /opt/fboss/share/platform_configs/led_manager.json
I1015 02:00:45.050233 10378 FruPresenceExplorer.cpp:25] Detecting presence of FRUs
I1015 02:00:45.051052 10377 ThriftServer.cpp:836] Using thread manager (resource pools not enabled) on address/port 5971: runtime: thriftFlagNotSet, , thrift flag: false, enable gflag: false, disable g>
I1015 02:00:45.051445 10378 FruPresenceExplorer.cpp:40] Detected that FAN1 is present
I1015 02:00:45.052593 10378 FruPresenceExplorer.cpp:40] Detected that FAN2 is present
I1015 02:00:45.053579 10378 FruPresenceExplorer.cpp:40] Detected that FAN3 is present
I1015 02:00:45.054590 10378 FruPresenceExplorer.cpp:40] Detected that FAN4 is present
I1015 02:00:45.055589 10378 FruPresenceExplorer.cpp:40] Detected that FAN5 is present
I1015 02:00:45.055612 10378 FruPresenceExplorer.cpp:40] Detected that FAN6 is present
I1015 02:00:45.055628 10378 FruPresenceExplorer.cpp:40] Detected that PEM1 is present
I1015 02:00:45.055646 10378 LedManager.cpp:45] Programming PEM LED with true
I1015 02:00:45.055697 10378 LedManager.cpp:80] Wrote 1 to file /sys/class/leds/psu_led:green:status/brightness
I1015 02:00:45.055727 10378 LedManager.cpp:80] Wrote 0 to file /sys/class/leds/psu_led:red:status/brightness
I1015 02:00:45.055735 10378 LedManager.cpp:55] Programmed PEM LED with presence true
I1015 02:00:45.055741 10378 LedManager.cpp:45] Programming FAN LED with true
I1015 02:00:45.055766 10378 LedManager.cpp:80] Wrote 1 to file /sys/class/leds/fan_led:green:status/brightness
I1015 02:00:45.055790 10378 LedManager.cpp:80] Wrote 0 to file /sys/class/leds/fan_led:red:status/brightness
I1015 02:00:45.055797 10378 LedManager.cpp:55] Programmed FAN LED with presence true
I1015 02:00:45.055803 10378 LedManager.cpp:25] Programming system LED with true
I1015 02:00:45.055826 10378 LedManager.cpp:80] Wrote 1 to file /sys/class/leds/sys_led:green:status/brightness
I1015 02:00:45.055865 10378 LedManager.cpp:80] Wrote 0 to file /sys/class/leds/sys_led:red:status/brightness
I1015 02:00:45.055871 10378 LedManager.cpp:34] Programmed system LED with true

@facebook-github-bot
Copy link
Contributor

@joancaneus has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@Scott8440 Scott8440 closed this Aug 14, 2025
raghav-nexthop pushed a commit to nexthop-ai/fboss that referenced this pull request Feb 6, 2026
<!-- Thanks for submitting a pull request! We appreciate you spending
the time to work on these changes. Please provide enough information so
that others can review your pull request. -->

**Pre-submission checklist**
- [x] I've ran the linters locally and fixed lint errors related to the
files I modified in this PR. You can install the linters by running `pip
install -r requirements-dev.txt && pre-commit install`
- [x] `pre-commit run`

# Summary

<!-- Explain the motivation for making this change and any other context
that you think would help reviewers of your code. What existing problem
does the pull request solve? -->
Added missing comma in the tests/agent_hw/t0_sai_tests_dpln.py
# Test Plan

<!-- Demonstrate the code is solid. Example: The exact commands you ran
and their output, screenshots / videos if the pull request changes the
user interface. How exactly did you verify that your PR solves the issue
you wanted to solve? -->

<!-- If a relevant Github issue exists for this PR, please make sure you
link that issue to this PR -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants