montblanc:config: Added RUNBMC_THERMAL_SENSOR in sensor config #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description:- ----------- The RUNBMC_THERMAL_SENSOR entry, which was previously absent, has been added to the sensor configuration Motivation:- ----------- The RUNBMC_THERMAL_SENSOR entry in the sensor service configuration was missing the sensor_config file specification. This has been corrected, ensuring the sensor service now monitors the BMC card's thermal value Testcase:- --------- 1.Run the jq to format json file. 2.Run the latest platform_manager 3.Validated the Sensor_service
Contributor
|
@kimdo8736 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@kimdo8736 merged this pull request in 773262e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:-
The RUNBMC_THERMAL_SENSOR entry, which was previously absent, has been added to the sensor configuration
Motivation:-
The RUNBMC_THERMAL_SENSOR entry in the sensor service configuration was missing the sensor_config file specification.
This has been corrected, ensuring the sensor service now monitors the BMC card's thermal value
Testcase:-
1.Run the jq to format json file.
sensor_service.txt
2.Run the latest platform_manager
3.Validated the Sensor_service
sensor_service_ut.txt
2946 SensorServiceImpl.cpp:95] Processing MINIPACK3_BMC PMUnit: 1 sensors 2946 SensorServiceImpl.cpp:186] RUNBMC_THERMAL_SENSOR (/run/devmap/sensors/RUNBMC_THERMAL_SENSOR/temp1_input) : 18.5