enable fw_util for Darwin platforms #352
Conversation
|
@joancaneus has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@arajeev-ARISTA has updated the pull request. You must reimport the pull request before landing. |
arajeev-ARISTA
force-pushed
the
enable_darwin_fw_util
branch
from
cae0a09 to
ff7fcb1
Compare
|
@arajeev-ARISTA has updated the pull request. You must reimport the pull request before landing. |
|
@arajeev-ARISTA, could you please make the necessary changes in the FwUtilVersionHandler class?. We restructured the code base. |
arajeev-ARISTA
force-pushed
the
enable_darwin_fw_util
branch
from
ff7fcb1 to
80ea2cb
Compare
|
@arajeev-ARISTA has updated the pull request. You must reimport the pull request before landing. |
Done! |
|
@ezeob002 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Removed the check which restricted the use of fw_util in Darwin and Darwin48V systems. Darwin firmware versions will still be printed using the special function `printDarwinVersion()`. This ensures that fw_util remains compliant with Darwin systems that have older BSP versions, which use a different type of firmware version sysfs entry. ### Testing Verified fw upgrade/downgrade with fw_util in a Darwin48V system. Also verified reading firmware versions in a Darwin system. Pull Request resolved: facebook#352 Reviewed By: joancaneus Differential Revision: D71937785 Pulled By: ezeob002 fbshipit-source-id: 77e8452ab6d1ed29dab15607ea763aa0df3c77b7
3 participants
Summary
Removed the check which restricted the use of fw_util in Darwin and Darwin48V systems.
Darwin firmware versions will still be printed using the special function
printDarwinVersion(). This ensures that fw_util remains compliant with Darwin systems that have older BSP versions, which use a different type of firmware version sysfs entry.Testing
Verified fw upgrade/downgrade with fw_util in a Darwin48V system. Also verified reading firmware versions in a Darwin system.