Skip to content

Conversation

@jaganathK-celestica
Copy link

Description:
This pull request modifies the I2cExplorer class to improve I2C device management. Key changes include:

  • Added deleteI2cDevice function to remove I2C devices.
  • Added getI2cEepromPath function to get eeprom path.

Motivation:
The motivation behind these changes is to enhance the reliability of I2C device management for I2cEeproms. There were missing functions to access oobeeprom such as i2c device deletion and getting eeprom path. The deleteI2cDevice function ensures a consistent approach to device removal. Adding getI2cEepromPath function provides an easy way to get the eeprom path.

Testing:
The changes were tested by:

  • Manually verifying the creation and deletion of I2C devices on a test platform.
  • Confirming that error conditions are handled correctly, and appropriate error messages are logged.
  • Tested the getI2cEepromPath function to ensure correct path generated and ensured error handling.

Unit test:
Logs after merging PR's [1/3]common: I2cExplorer, [2/3]common: fw_utils and [3/3]tahan: config
upgrade_log.txt
downgrade_log.txt

@facebook-github-bot
Copy link
Contributor

@joancaneus has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jaganathK-celestica jaganathK-celestica changed the title [1/3]common: I2cExplorer: Implement i2cdevice deletion and eeprom path extraction for oob_eeprom [1/3]OOB_eeprom support: common: I2cExplorer: Implement i2cdevice deletion and eeprom path extraction Apr 15, 2025
@facebook-github-bot
Copy link
Contributor

@jaganathK-celestica has updated the pull request. You must reimport the pull request before landing.

@Scott8440
Copy link
Contributor

@jaganathK-celestica I2C eeprom devices are now supported natively: a06e847

I believe this stack is unnecessary now.

@Scott8440 Scott8440 closed this Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants