[3/3]OOB_eeprom support: tahan: config: fw_util json modification for Tahan platform #363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@joancaneus has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
jaganathK-celestica
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request modifies the "oob_eeprom" firmware upgrade process by replacing the manual I2C device creation and dynamic dd commands with a new i2cEeprom command. This change simplifies the upgrade operation for the OOB EEPROM.
Motivation:
The previous implementation of the oob_eeprom upgrade process involved multiple steps, including I2C bus reads, dynamic I2C device creation, and dd commands to read and write to the EEPROM. By introducing the i2cEeprom command, we encapsulate these steps into a single, more manageable operation. This improves readability, reduces the potential for errors, and simplifies maintenance.
Testing:
The changes were tested by:
Unit test:
Logs after merging PR's [1/3]common: I2cExplorer, [2/3]common: fw_utils and [3/3]tahan: config
upgrade_log.txt
downgrade_log.txt
jq_log.txt