[Nexthop] Allow passing a timeout to unit tests#654
Closed
benoit-nexthop wants to merge 1 commit intofacebook:mainfrom
Closed
[Nexthop] Allow passing a timeout to unit tests#654benoit-nexthop wants to merge 1 commit intofacebook:mainfrom
benoit-nexthop wants to merge 1 commit intofacebook:mainfrom
Conversation
Allow passing a timeout to unit tests When running unit tests, no timeout was enforced. Add an optional `--timeout` flag to `getdeps.py` that is passed to `ctest` and update our build script to set a default timeout of 90 seconds per test, which is generous enough for now. Existing unit tests pass within the given timeout.
benoit-nexthop
changed the title
Contributor
|
@KevinYakar has imported this pull request. If you are a Meta employee, you can view this in D86883098. |
meta-codesync bot
pushed a commit
to facebook/CacheLib
that referenced
this pull request
Nov 14, 2025
Summary: **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` When running unit tests, no timeout was enforced. Add an optional `--timeout` flag to `getdeps.py` that is passed to `ctest` and update our build script to set a default timeout of 90 seconds per test, which is generous enough for now. X-link: facebook/fboss#654 Reviewed By: ahornby Differential Revision: D86883098 Pulled By: KevinYakar fbshipit-source-id: 9c841311460a546ae9189ddf62ee461aad948871
meta-codesync bot
pushed a commit
to facebook/folly
that referenced
this pull request
Nov 14, 2025
Summary: **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` When running unit tests, no timeout was enforced. Add an optional `--timeout` flag to `getdeps.py` that is passed to `ctest` and update our build script to set a default timeout of 90 seconds per test, which is generous enough for now. X-link: facebook/fboss#654 Reviewed By: ahornby Differential Revision: D86883098 Pulled By: KevinYakar fbshipit-source-id: 9c841311460a546ae9189ddf62ee461aad948871
meta-codesync bot
pushed a commit
to facebook/mvfst
that referenced
this pull request
Nov 14, 2025
Summary: **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` When running unit tests, no timeout was enforced. Add an optional `--timeout` flag to `getdeps.py` that is passed to `ctest` and update our build script to set a default timeout of 90 seconds per test, which is generous enough for now. X-link: facebook/fboss#654 Reviewed By: ahornby Differential Revision: D86883098 Pulled By: KevinYakar fbshipit-source-id: 9c841311460a546ae9189ddf62ee461aad948871
Contributor
|
@KevinYakar merged this pull request in ddb20ad. |
meta-codesync bot
pushed a commit
to facebook/openr
that referenced
this pull request
Nov 14, 2025
Summary: **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` When running unit tests, no timeout was enforced. Add an optional `--timeout` flag to `getdeps.py` that is passed to `ctest` and update our build script to set a default timeout of 90 seconds per test, which is generous enough for now. X-link: facebook/fboss#654 Reviewed By: ahornby Differential Revision: D86883098 Pulled By: KevinYakar fbshipit-source-id: 9c841311460a546ae9189ddf62ee461aad948871
meta-codesync bot
pushed a commit
to facebookexperimental/moxygen
that referenced
this pull request
Nov 14, 2025
Summary: **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` When running unit tests, no timeout was enforced. Add an optional `--timeout` flag to `getdeps.py` that is passed to `ctest` and update our build script to set a default timeout of 90 seconds per test, which is generous enough for now. X-link: facebook/fboss#654 Reviewed By: ahornby Differential Revision: D86883098 Pulled By: KevinYakar fbshipit-source-id: 9c841311460a546ae9189ddf62ee461aad948871
meta-codesync bot
pushed a commit
to facebook/wangle
that referenced
this pull request
Nov 14, 2025
Summary: **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` When running unit tests, no timeout was enforced. Add an optional `--timeout` flag to `getdeps.py` that is passed to `ctest` and update our build script to set a default timeout of 90 seconds per test, which is generous enough for now. X-link: facebook/fboss#654 Reviewed By: ahornby Differential Revision: D86883098 Pulled By: KevinYakar fbshipit-source-id: 9c841311460a546ae9189ddf62ee461aad948871
meta-codesync bot
pushed a commit
to facebookincubator/hsthrift
that referenced
this pull request
Nov 14, 2025
Summary: **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` When running unit tests, no timeout was enforced. Add an optional `--timeout` flag to `getdeps.py` that is passed to `ctest` and update our build script to set a default timeout of 90 seconds per test, which is generous enough for now. X-link: facebook/fboss#654 Reviewed By: ahornby Differential Revision: D86883098 Pulled By: KevinYakar fbshipit-source-id: 9c841311460a546ae9189ddf62ee461aad948871
meta-codesync bot
pushed a commit
to facebook/fbthrift
that referenced
this pull request
Nov 14, 2025
Summary: **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` When running unit tests, no timeout was enforced. Add an optional `--timeout` flag to `getdeps.py` that is passed to `ctest` and update our build script to set a default timeout of 90 seconds per test, which is generous enough for now. X-link: facebook/fboss#654 Reviewed By: ahornby Differential Revision: D86883098 Pulled By: KevinYakar fbshipit-source-id: 9c841311460a546ae9189ddf62ee461aad948871
meta-codesync bot
pushed a commit
to facebookincubator/katran
that referenced
this pull request
Nov 14, 2025
Summary: **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` When running unit tests, no timeout was enforced. Add an optional `--timeout` flag to `getdeps.py` that is passed to `ctest` and update our build script to set a default timeout of 90 seconds per test, which is generous enough for now. X-link: facebook/fboss#654 Reviewed By: ahornby Differential Revision: D86883098 Pulled By: KevinYakar fbshipit-source-id: 9c841311460a546ae9189ddf62ee461aad948871
meta-codesync bot
pushed a commit
to facebookexperimental/edencommon
that referenced
this pull request
Nov 14, 2025
Summary: **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` When running unit tests, no timeout was enforced. Add an optional `--timeout` flag to `getdeps.py` that is passed to `ctest` and update our build script to set a default timeout of 90 seconds per test, which is generous enough for now. X-link: facebook/fboss#654 Reviewed By: ahornby Differential Revision: D86883098 Pulled By: KevinYakar fbshipit-source-id: 9c841311460a546ae9189ddf62ee461aad948871
meta-codesync bot
pushed a commit
to facebookincubator/cinderx
that referenced
this pull request
Nov 14, 2025
Summary: **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` When running unit tests, no timeout was enforced. Add an optional `--timeout` flag to `getdeps.py` that is passed to `ctest` and update our build script to set a default timeout of 90 seconds per test, which is generous enough for now. X-link: facebook/fboss#654 Reviewed By: ahornby Differential Revision: D86883098 Pulled By: KevinYakar fbshipit-source-id: 9c841311460a546ae9189ddf62ee461aad948871
meta-codesync bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Nov 14, 2025
Summary: **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` When running unit tests, no timeout was enforced. Add an optional `--timeout` flag to `getdeps.py` that is passed to `ctest` and update our build script to set a default timeout of 90 seconds per test, which is generous enough for now. X-link: facebook/fboss#654 Reviewed By: ahornby Differential Revision: D86883098 Pulled By: KevinYakar fbshipit-source-id: 9c841311460a546ae9189ddf62ee461aad948871
meta-codesync bot
pushed a commit
to facebookincubator/fizz
that referenced
this pull request
Nov 14, 2025
Summary: **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` When running unit tests, no timeout was enforced. Add an optional `--timeout` flag to `getdeps.py` that is passed to `ctest` and update our build script to set a default timeout of 90 seconds per test, which is generous enough for now. X-link: facebook/fboss#654 Reviewed By: ahornby Differential Revision: D86883098 Pulled By: KevinYakar fbshipit-source-id: 9c841311460a546ae9189ddf62ee461aad948871
meta-codesync bot
pushed a commit
to facebook/proxygen
that referenced
this pull request
Nov 14, 2025
Summary: **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` When running unit tests, no timeout was enforced. Add an optional `--timeout` flag to `getdeps.py` that is passed to `ctest` and update our build script to set a default timeout of 90 seconds per test, which is generous enough for now. X-link: facebook/fboss#654 Reviewed By: ahornby Differential Revision: D86883098 Pulled By: KevinYakar fbshipit-source-id: 9c841311460a546ae9189ddf62ee461aad948871
meta-codesync bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Nov 14, 2025
Summary: **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` When running unit tests, no timeout was enforced. Add an optional `--timeout` flag to `getdeps.py` that is passed to `ctest` and update our build script to set a default timeout of 90 seconds per test, which is generous enough for now. X-link: facebook/fboss#654 Reviewed By: ahornby Differential Revision: D86883098 Pulled By: KevinYakar fbshipit-source-id: 9c841311460a546ae9189ddf62ee461aad948871
meta-codesync bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Nov 14, 2025
Summary: **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` When running unit tests, no timeout was enforced. Add an optional `--timeout` flag to `getdeps.py` that is passed to `ctest` and update our build script to set a default timeout of 90 seconds per test, which is generous enough for now. X-link: facebook/fboss#654 Reviewed By: ahornby Differential Revision: D86883098 Pulled By: KevinYakar fbshipit-source-id: 9c841311460a546ae9189ddf62ee461aad948871
meta-codesync bot
pushed a commit
to facebook/fb303
that referenced
this pull request
Nov 14, 2025
Summary: **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` When running unit tests, no timeout was enforced. Add an optional `--timeout` flag to `getdeps.py` that is passed to `ctest` and update our build script to set a default timeout of 90 seconds per test, which is generous enough for now. X-link: facebook/fboss#654 Reviewed By: ahornby Differential Revision: D86883098 Pulled By: KevinYakar fbshipit-source-id: 9c841311460a546ae9189ddf62ee461aad948871
meta-codesync bot
pushed a commit
to facebook/watchman
that referenced
this pull request
Nov 14, 2025
Summary: **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` When running unit tests, no timeout was enforced. Add an optional `--timeout` flag to `getdeps.py` that is passed to `ctest` and update our build script to set a default timeout of 90 seconds per test, which is generous enough for now. X-link: facebook/fboss#654 Reviewed By: ahornby Differential Revision: D86883098 Pulled By: KevinYakar fbshipit-source-id: 9c841311460a546ae9189ddf62ee461aad948871
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
When running unit tests, no timeout was enforced. Add an optional
--timeoutflag togetdeps.pythat is passed toctestand updateour build script to set a default timeout of 90 seconds per test, which
is generous enough for now.
Test Plan
Existing unit tests pass within a given timeout (e.g. 90 seconds).