Skip to content

Ladakh800bcls: Platform: Add temperature config and power config in sensor service#692

Closed
chee-zhang wants to merge 2 commits intofacebook:mainfrom
chee-zhang:ladakh800bcls_add_temperature_config
Closed

Ladakh800bcls: Platform: Add temperature config and power config in sensor service#692
chee-zhang wants to merge 2 commits intofacebook:mainfrom
chee-zhang:ladakh800bcls_add_temperature_config

Conversation

@chee-zhang
Copy link
Contributor

@chee-zhang chee-zhang commented Nov 24, 2025

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run
clang-format.........................................(no files to check)Skipped
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check json...............................................................Passed
check for merge conflicts................................................Passed

Summary

This PR is to add temperature config and power config in sensor service.

Add temperature config

  • To check the ASIC temperature, need to add the remote temperature of tmp432 sensor on the chip.
  • Only temp2 on chan 3, temp2 and temp3 on chan 1 are needed.
tmp432-i2c-44-4c
Adapter: i2c-8-mux (chan_id 3)
temp1:        +45.6°C  (low  =  +0.0°C, high = +100.0°C)
                       (crit = +85.0°C, hyst = +75.0°C)
temp2:        +45.6°C  (low  =  +0.0°C, high = +100.0°C)
                       (crit = +85.0°C, hyst = +75.0°C)
temp3:         +0.0°C  (low  =  +0.0°C, high = +85.0°C)
                       (crit = +85.0°C, hyst = +75.0°C)

tmp432-i2c-50-4c
Adapter: i2c-25-mux (chan_id 1)
temp1:        +53.0°C  (low  =  +0.0°C, high = +100.0°C)
                       (crit = +85.0°C, hyst = +75.0°C)
temp2:        +44.0°C  (low  =  +0.0°C, high = +100.0°C)
                       (crit = +85.0°C, hyst = +75.0°C)
temp3:        +45.2°C  (low  =  +0.0°C, high = +100.0°C)
                       (crit = +85.0°C, hyst = +75.0°C)

tmp432-i2c-42-4c
Adapter: i2c-8-mux (chan_id 1)
temp1:        +52.3°C  (low  =  +0.0°C, high = +100.0°C)
                       (crit = +85.0°C, hyst = +75.0°C)
temp2:        +44.8°C  (low  =  +0.0°C, high = +100.0°C)
                       (crit = +85.0°C, hyst = +75.0°C)
temp3:        +45.8°C  (low  =  +0.0°C, high = +100.0°C)
                       (crit = +85.0°C, hyst = +75.0°C)

tmp432-i2c-52-4c
Adapter: i2c-25-mux (chan_id 3)
temp1:        +46.8°C  (low  =  +0.0°C, high = +100.0°C)
                       (crit = +85.0°C, hyst = +75.0°C)
temp2:        +43.9°C  (low  =  +0.0°C, high = +100.0°C)
                       (crit = +85.0°C, hyst = +75.0°C)
temp3:         +0.0°C  (low  =  +0.0°C, high = +85.0°C)
                       (crit = +85.0°C, hyst = +75.0°C)

Add powerConfig

  • Add 48V HOTSWAP LTC4287
  • Add 6 fans
  • Add 48 V HOTSWAP TPS16851 power estimation

Test Plan

Test Report

The sensor_service_hw_test passed.

I1004 20:14:05.775893 269584 SensorServiceImpl.cpp:329] HSC: Power 2886.4W (Based on Power Sensor: HSCB_UP1_XP48R0V_HOTSWAP_PIN)
I1004 20:14:05.775897 269584 SensorServiceImpl.cpp:347] MCB_U167_FAN1_INA238_POWER: Power 2.87W (Direct Sensor)
I1004 20:14:05.775901 269584 SensorServiceImpl.cpp:347] MCB_U168_FAN2_INA238_POWER: Power 3.3536W (Direct Sensor)
I1004 20:14:05.775904 269584 SensorServiceImpl.cpp:347] MCB_U169_FAN3_INA238_POWER: Power 3.376W (Direct Sensor)
I1004 20:14:05.775908 269584 SensorServiceImpl.cpp:347] MCB_U170_FAN4_INA238_POWER: Power 3.4032W (Direct Sensor)
I1004 20:14:05.775911 269584 SensorServiceImpl.cpp:347] MCB_U188_FAN5_INA238_POWER: Power 3.3512W (Direct Sensor)
I1004 20:14:05.775914 269584 SensorServiceImpl.cpp:347] MCB_U189_FAN6_INA238_POWER: Power 2.8112W (Direct Sensor)
I1004 20:14:05.775918 269584 SensorServiceImpl.cpp:357] Adding power delta: 10W
I1004 20:14:05.775925 269584 SensorServiceImpl.cpp:392] ASIC1: Temperature 47°C (Based on SMB_L_U29_LEFT_TMP432_1_TEMP3).  Failures: 0
I1004 20:14:05.775930 269584 SensorServiceImpl.cpp:392] ASIC2: Temperature 45°C (Based on SMB_R_U29_LEFT_TMP432_1_TEMP3).  Failures: 0
I1004 20:14:05.775937 269584 SensorServiceImpl.cpp:429] Max Input Voltage: 48.971V (Based on HSCB_UP1_XP48R0V_HOTSWAP_VIN).  Processed: 7/7
I1004 20:14:05.775941 269584 SensorServiceImpl.cpp:138] Summary: Processed 667 Sensors. 0 Failures.
[       OK ] SensorServiceHwTest.CheckAllSensors (661 ms)
[----------] 6 tests from SensorServiceHwTest (12902 ms total)

[----------] Global test environment tear-down
[==========] 6 tests from 1 test suite ran. (12902 ms total)
[  PASSED  ] 6 tests.

sensor_service_hw_test.log

@meta-cla meta-cla bot added the CLA Signed label Nov 24, 2025
@chee-zhang chee-zhang changed the title Ladakh800bcls: Platform: Add temperature config in sensor service Ladakh800bcls: Platform: Add temperature config and power config in sensor service Nov 24, 2025
@meta-codesync
Copy link

meta-codesync bot commented Nov 24, 2025

@somasun has imported this pull request. If you are a Meta employee, you can view this in D87795382.

@meta-codesync
Copy link

meta-codesync bot commented Nov 24, 2025

@somasun merged this pull request in cebd069.

@chee-zhang chee-zhang deleted the ladakh800bcls_add_temperature_config branch February 28, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants