[Nexthop] Conditionally build sai_switch_reachability_change_speed on supported platform#734
Open
marif-nexthop wants to merge 1 commit intofacebook:mainfrom
Open
Conversation
… supported platform (DNX) only (facebook#205) <!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. --> **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` # Summary <!-- Explain the motivation for making this change and any other context that you think would help reviewers of your code. What existing problem does the pull request solve? --> The `sai_switch_reachability_change_speed` benchmark is only applicable to DNX platforms and is not supported on XGS platforms. Previously, this benchmark was built for all SAI_BRCM_IMPL builds and would hang/crash at runtime when executed on XGS platforms. This change updates `cmake/AgentHwSaiBenchmarks.cmake` to conditionally include the benchmark only when: - SAI_SDK_VERSION contains "DNX", OR - Building with BUILD_SAI_FAKE (same as original code) This prevents the binary from being built on XGS platforms entirely, avoiding runtime hangs/crashes. # Test Plan Verified that `sai_switch_reachability_change_speed-sai_impl` is not built on XGS platform. <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. How exactly did you verify that your PR solves the issue you wanted to solve? --> <!-- If a relevant Github issue exists for this PR, please make sure you link that issue to this PR -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
The
sai_switch_reachability_change_speedbenchmark is only applicable to DNX platforms and is not supported on XGS platforms.Previously, this benchmark was built for all SAI_BRCM_IMPL builds and would hang/crash at runtime when executed on XGS platforms.
This change updates
cmake/AgentHwSaiBenchmarks.cmaketo conditionally include the benchmark only when:This prevents the binary from being built on XGS platforms entirely, avoiding runtime hangs/crashes.
Test Plan
Verified that
sai_switch_reachability_change_speed-sai_implis not built on XGS platform.