Tahansb800bc: config: update smb th6 related sensors threshold#738
Closed
CliffyWong wants to merge 1 commit intofacebook:mainfrom
Closed
Tahansb800bc: config: update smb th6 related sensors threshold#738CliffyWong wants to merge 1 commit intofacebook:mainfrom
CliffyWong wants to merge 1 commit intofacebook:mainfrom
Conversation
Contributor
|
@mikechoifb has imported this pull request. If you are a Meta employee, you can view this in D89735558. |
Contributor
|
@mikechoifb merged this pull request in ef8d708. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
This PR is for updating the threshold of several smb TH6 related sensors
Motivation
This PR includes the following changes:
1.Update the max alarm threshold of SMB_VDDCORE&SMB_ASIC_VOLTAGE iout sensors based on the sensors hardware design for TH6 B0+.
Updated sensor list:
SMB_PU2978_XP0R8V_TH6_VDDC_IOUT
SMB_PU1342_XP0R8V_PT_VDDC_1_IOUT
SMB_PU1502_XP0R75V_TH6_TRVDD_0_IOUT
SMB_PU1502_XP0R8V_PT_VDDC_2_IOUT
SMB_PU2056_XP0R8V_PT_VDDC_3_IOUT
SMB_PU2056_XP0R8V_PT_VDDC_4_IOUT
SMB_PU1937_XP0R8V_PT_VDDC_5_IOUT
SMB_PU2052_XP0R8V_PT_VDDC_6_IOUT
SMB_PU1745_XP0R8V_PT_VDDC_7_IOUT
2.Update the min alarm threshold of iin/iout sensors since vendor suggested :
"About negative current during 0A load，this is due to Imon accuracy. In this application, IIN is calculated based Vin，Vout，Iout and register setting in the Input Power Estimate Settings.
Therefore , adjust lower threshold as:
updated sensor list：
MCB_PU1497_XP3R3V_OSFP_IIN/OUT
MCB_PU1497_XP3R3V_OSFP_POUT
SMB_PU2978_XP0R8V_TH6_VDDC_IIN/IOUT
SMB_PU2203_XP0R8V_PT_VDDC_0_IIN/IOUT
SMB_PU2203_XP0R72V_PB_TRVDD_0_IIN/IOUT
SMB_PU1502_XP0R75V_TH6_TRVDD_0_IIN/IOUT
SMB_PU1502_XP0R8V_PT_VDDC_2_IIN/IOUT
SMB_PU2056_XP0R8V_PT_VDDC_3_IIN/IOUT
SMB_PU2056_XP0R8V_PT_VDDC_4_IIN/IOUT
SMB_PU1745_XP0R8V_PT_VDDC_7_IIN/IOUT
SMB_PU1745_XP0R72V_PB_TRVDD_2_IIN/IOUT
SMB_PU1342_XP0R8V_PT_VDDC_1_IIN/IOUT
SMB_PU1342_XP1R5V_TH6_RVDD_0_IIN/IOUT
SMB_PU2052_XP0R8V_PT_VDDC_6_IIN/IOUT
SMB_PU2052_XP1R5V_TH6_RVDD_1_IIN/IOUT
SMB_PU1937_XP0R75V_TH6_TRVDD_1_IIN/IOUT
SMB_PU1937_XP0R8V_PT_VDDC_5_IIN/IOUT
SMB_PU1497_XP0R9V_TH6_TRVDD_0_IIN/IOUT
SMB_PU1497_XP0R72V_PB_TRVDD_1_IIN/IOUT
SMB_PU1746_XP0R9V_TH6_TRVDD_1_IIN/IOUT
SMB_PU1746_XP0R72V_PB_TRVDD_3_IIN/IOUT
Test Plan
1.Run platform_manager/sensor_service/fan_service/data_corral_service on the device successfully, used sensor_service_client to catch the snapshot of sensors:
Pls refer the full logs: PM Services.zip
2.Run all hw_test cases, passed.
Pls refer the full logs: HwTest.zip