montblanc:config: update SMB_VDDC_VRM_Vout threshold#740
Closed
JunjunGu2 wants to merge 1 commit intofacebook:mainfrom
Closed
montblanc:config: update SMB_VDDC_VRM_Vout threshold#740JunjunGu2 wants to merge 1 commit intofacebook:mainfrom
JunjunGu2 wants to merge 1 commit intofacebook:mainfrom
Conversation
…t threshold Signed-off-by: Junjun Gu <junjun.gu@celestica.com>
Contributor
|
@mikechoifb has imported this pull request. If you are a Meta employee, you can view this in D89735326. |
Contributor
|
@mikechoifb merged this pull request in fa3f848. |
itskittycisco
pushed a commit
to itskittycisco/fboss
that referenced
this pull request
Feb 11, 2026
Summary: **Pre-submission checklist** - [ ] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [ ] `pre-commit run`  This PR is to update the sensor thresholds for SMB_VDDC_VRM_Vout. According to HW team, for sensor SMB_VDDC_VRM_Vout threshold, Max_Alarm 0.8V Max_Design 0.81V are not reasonable. So Hw update the threshold. Change the values to Max_Alarm 0.8289V Max_Design 0.839V. Pull Request resolved: facebook#740 Test Plan: Run platform_manager/sensor_serive/sensor_service_client to check the SMB_VDDC_VRM_Vout threshold has been set correctly.  [pm.txt](https://github.com/user-attachments/files/24118673/pm.txt) [sensors.txt](https://github.com/user-attachments/files/24118675/sensors.txt) Reviewed By: RomanChoporov-Meta Differential Revision: D89735326 Pulled By: mikechoifb fbshipit-source-id: 02c174f4b3bdad28485fd5e3002b415fa056e025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
This PR is to update the sensor thresholds for SMB_VDDC_VRM_Vout.
According to HW team, for sensor SMB_VDDC_VRM_Vout threshold, Max_Alarm 0.8V Max_Design 0.81V are not reasonable. So Hw update the threshold. Change the values to Max_Alarm 0.8289V Max_Design 0.839V.
Test Plan
Run platform_manager/sensor_serive/sensor_service_client to check the SMB_VDDC_VRM_Vout threshold has been set correctly.
pm.txt
sensors.txt