Open
Conversation
Summary: Execution style chosen: All of them. This uses a backtracking implementation by default, but, unless it can prove it isn't needed, will track the number of backtracks that occur and fall back to the NFA, or, if available, DFA executor if too many occur. This gets the perf benefits for the backtracking implementation by default in most cases, while also countering the worst-case-scenario. For the benchmarks, Folly's implementation manages at least one, sometimes two, orders of magnitude improvement vs. the other regex implementations. The only implementations it currently falls behind in are a couple where RE2 wins, and a couple where CTRE wins. In cases where it's out-performed, it still manages to get very close to the performance of the other libraries :) Work is still ongoing, the PR is only to see how the OSS tests behave. Differential Revision: D97922157
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Execution style chosen: All of them.
This uses a backtracking implementation by default, but, unless it can prove it isn't needed, will track the number of backtracks that occur and fall back to the NFA, or, if available, DFA executor if too many occur. This gets the perf benefits for the backtracking implementation by default in most cases, while also countering the worst-case-scenario.
For the benchmarks, Folly's implementation manages at least one, sometimes two, orders of magnitude improvement vs. the other regex implementations. The only implementations it currently falls behind in are a couple where RE2 wins, and a couple where CTRE wins. In cases where it's out-performed, it still manages to get very close to the performance of the other libraries :)
Work is still ongoing, the PR is only to see how the OSS tests behave.
Differential Revision: D97922157