test-e2e: Attemp to bisect the CI failure#821
Closed
cortinico wants to merge 5 commits into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
Author
|
Should be fixed by facebook/react-native#34797 |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Sep 27, 2022
Summary: Release versions are currently broken on `main`. This happened once we bumped the AGP version to 7.3. It seems like that the path we used to use for assets has changed. The app build successfully but it fails to start as it can't load the bundle. This is also causing the hermes e2e test to fail: facebook/hermes#821 ## Changelog [Android] [Fixed] - Fix crash on release versions after AGP 7.3 bump Pull Request resolved: #34797 Test Plan: Tested this locally and it works fine with RN Tester (can run a release version of it). Plus, inspecting the zip: ### Before ``` $ unzip -l packages/rn-tester/android/app/build/outputs/apk/hermes/release/app-hermes-arm64-v8a-release.apk | grep android.bundle 1248608 01-01-1981 01:01 assets/mergeHermesReleaseAssets/RNTesterApp.android.bundle ``` ### After ``` $ unzip -l packages/rn-tester/android/app/build/outputs/apk/hermes/release/app-hermes-arm64-v8a-release.apk | grep android.bundle 1248608 01-01-1981 01:01 assets/RNTesterApp.android.bundle ``` Reviewed By: cipolleschi Differential Revision: D39847369 Pulled By: cortinico fbshipit-source-id: 0e21c0b6e58b49ac097c59223649b74b2879b5e5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempting to bisect the failure we're having on this e2e test by checking out the RN code before facebook/react-native@9f6711f which I believe could be the culprit here.